Skip to content

Fix deployment security regression boundaries - #237

Open
cashflaretech-glitch wants to merge 1 commit into
DigiNodes:mainfrom
cashflaretech-glitch:fix/sw-093-deployment-security-regression
Open

cashflaretech-glitch wants to merge 1 commit into
DigiNodes:mainfrom
cashflaretech-glitch:fix/sw-093-deployment-security-regression

Conversation

@cashflaretech-glitch

Copy link
Copy Markdown

Summary

Enforce Testnet-only deployment boundaries and redact secret-bearing child process output before exposing it to users.

Changes

  • Guard the deploy command so and similar values are rejected before any subprocesses launch.
  • Validate the deployment identity alias while preserving the existing MVP safety model.
  • Redact secret-like values such as from terminal output.
  • Add regression coverage for the deployment boundary and output sanitation.

Verification

@diginodes/stellarforge-cli@0.1.0 test
vitest run

RUN v5.0.1 /workspaces/stellarforge-cli

Deploying smart contract to Stellar Testnet.
Running 1 project test workflow.

Test Files 32 passed (32)
Tests 162 passed | 1 skipped (163)
Start at 22:19:21
Duration 11.40s (tests 88%, import 6%, transform 5%, worker 2%)

Isolate  32 workers spawned · ~97ms startup each (spawn + environment, per file)
         at least ~3.01s faster with isolate: false — reuses workers across files instead of one per file

@diginodes/stellarforge-cli@0.1.0 typecheck
tsc -p tsconfig.json --noEmit

@diginodes/stellarforge-cli@0.1.0 lint
eslint .

@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 49467aa0-8416-42c4-ae54-a9e48d2071e1
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dDevAhmed

Copy link
Copy Markdown
Contributor

@cashflaretech-glitch where is the issue reference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants