Skip to content

test: enforce deterministic doctor result ordering - #243

Merged
dDevAhmed merged 1 commit into
DigiNodes:mainfrom
nice-bills:test/sw-028-doctor-deterministic-ordering
Oct 18, 2026
Merged

dDevAhmed merged 1 commit into
DigiNodes:mainfrom
nice-bills:test/sw-028-doctor-deterministic-ordering

Conversation

@nice-bills

Copy link
Copy Markdown
Contributor

Closes #131

Summary

Doctor results now always follow check registration order. runDiagnostics snapshots the check list before running, so mutating it mid-run can no longer reorder, skip, or duplicate results. Aggregation is unchanged.

Changes

  • run.ts: snapshot checks, run sequentially
  • doctor.ts: export createDefaultDiagnostics()
  • tests/doctor-ordering.test.ts: 8 mocked tests (order, throwing checks, repeat runs, summary, default order)

Testing

typecheck, lint, format, build pass. npm test: 168 passed, 1 skipped. 2 new tests fail on main.

No security impact. No changeset needed (no user-visible change).

Copilot AI balanced review requested due to automatic review settings October 17, 2026 11:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a6834637-7969-4e27-b7d8-611a4fc1ded4
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dDevAhmed
dDevAhmed merged commit e3125cc into DigiNodes:main Oct 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SW-028 — Enforce deterministic doctor result ordering

3 participants