Skip to content

test(cli): add deploy E2E, error-category wording, non-TTY, and Quick Start verification suites - #244

Merged
dDevAhmed merged 1 commit into
DigiNodes:mainfrom
ykargeee-bit:feature/cli-verification-suites
Oct 18, 2026
Merged

dDevAhmed merged 1 commit into
DigiNodes:mainfrom
ykargeee-bit:feature/cli-verification-suites

Conversation

@ykargeee-bit

Copy link
Copy Markdown
Contributor

Summary

Adds the verification suites for SW-092, SW-096, SW-097, and SW-099:

  • mocked Stellar Testnet deploy end-to-end fixtures (unsafe source rejection, secret non-reflection, deterministic success output, typed subprocess failure);
  • centralized CLI error-category wording plus the stable exit-code contract, including alignment with docs/reference/exit-codes.md;
  • non-TTY output readability (plain newline-terminated lines, ANSI/control stripping, no TTY assumptions, unchanged exit semantics);
  • Quick Start documentation verification against the bundled template registry, dev-script selection order, doctor exit code, and Testnet/secret boundaries.

No production code paths are changed; these suites lock down existing, documented behavior.

Testing

  • npm test (Vitest) — new suites live under tests/: deploy-testnet-e2e.test.ts, error-category-wording.test.ts, non-tty-output.test.ts, quick-start-docs.test.ts.
  • All child processes are mocked; no live Stellar network, identity, or secret material is required.
  • npm run typecheck, npm run lint, and npm run format:check expectations are unchanged.

Security

  • The suites assert that rejected secret-bearing inputs and internal error causes are never reflected in user-facing output.
  • Deploy tests use a fake child process only; no real stellar invocation, signing key, or network access.
  • Exit-code semantics (0-5) are preserved and asserted against the documented contract.

Closes #192
Closes #196
Closes #197
Closes #199

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 613003d6-b66b-4555-afd9-7c0af3f2972f
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dDevAhmed
dDevAhmed merged commit 0c5c9a7 into DigiNodes:main Oct 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants