Skip to content

test(config): add identity-alias, network-enum, precedence, and unified test orchestration suites - #246

Merged
dDevAhmed merged 1 commit into
DigiNodes:mainfrom
memplethee-lab:feature/config-validation-suites
Oct 18, 2026
Merged

dDevAhmed merged 1 commit into
DigiNodes:mainfrom
memplethee-lab:feature/config-validation-suites

Conversation

@memplethee-lab

Copy link
Copy Markdown
Contributor

Summary

Adds the SW-075, SW-078, SW-079, and SW-080 verification suites:

  • identity-alias boundaries: accepted named aliases (including the 64-character limit) versus rejected raw StrKeys, seed phrases, paths, metacharacters, whitespace, and non-string values, with no value echo in errors;
  • network-enum conformance: testnet/futurenet/mainnet accepted, everything else (including case variants, padded strings, and non-strings) rejected with the documented message, plus proof that deploy stays Testnet-only regardless of the configured network;
  • CLI-over-file precedence: explicit CLI option > project stellarforge.config.json > missing, partial overrides preserving the other project value, no implicit default, and confirmation that environment variables are not consulted;
  • a unified test-orchestration regression suite covering Node.js and Cargo workflow detection, precedence of the Node workflow, streaming success, typed failure propagation, and rejection of unsupported/malformed projects without starting any process.

No production code paths are changed; the suites lock down existing, documented behavior.

Testing

  • npm test (Vitest) — new suites live under tests/: config-identity-alias.test.ts, config-network-enum.test.ts, config-precedence.test.ts, test-orchestration-regression.test.ts.
  • Fixtures use temp directories only; no real project, network, or child process is started.
  • npm run typecheck, npm run lint, and npm run format:check expectations are unchanged.

Security

  • Rejected identity values are asserted never to be reflected in validation messages.
  • Precedence tests prove no implicit Mainnet default and no environment-variable injection of configuration.
  • Unsupported/malformed projects are asserted to fail before any subprocess is spawned.

Closes #175
Closes #178
Closes #179
Closes #180

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 585bcaaa-a75a-452d-b36d-e528e1a72b8b
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dDevAhmed
dDevAhmed merged commit 72d54d1 into DigiNodes:main Oct 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants