Skip to content

test(deploy,config): add deploy network rejection, remediation, reference, and secret non-reflection suites - #248

Merged
dDevAhmed merged 1 commit into
DigiNodes:mainfrom
devrabiuhussain:feature/deploy-and-config-verification
Oct 18, 2026
Merged

dDevAhmed merged 1 commit into
DigiNodes:mainfrom
devrabiuhussain:feature/deploy-and-config-verification

Conversation

@devrabiuhussain

Copy link
Copy Markdown
Contributor

Summary

Adds the SW-082, SW-083, SW-084, and SW-085 verification suites:

  • deploy network rejection matrix: every non-Testnet value (case variants, padded strings, main/local/public/futurenet, empty) is rejected with the exact MVP message, the CLI path rejects before any subprocess starts, and the rejected value is never echoed;
  • missing-configuration remediation: the missing-network and missing-identity failures render distinct, actionable messages, resolve no plan and start no process, never fall back to an implicit Mainnet default, and proceed once the values are supplied on the CLI;
  • configuration reference verification: every json example in docs/reference/configuration.md parses and validates against the schema, uses only supported fields, contains no secret material, and the documented precedence example is honoured by the resolver;
  • a configuration secret non-reflection umbrella: secret-bearing field names, malformed JSON with embedded secrets, and unsupported fields are all rejected without echoing raw values, including through the CLI error boundary.

No production code paths are changed; the suites lock down existing, documented behavior.

Testing

  • npm test (Vitest) — new suites live under tests/: deploy-network-rejection.test.ts, deploy-missing-config-remediation.test.ts, configuration-reference-examples.test.ts, configuration-secret-reflection.test.ts.
  • Child processes are mocked; no live Stellar network, identity, or secret material is required. Documentation checks read the committed reference files.
  • npm run typecheck, npm run lint, and npm run format:check expectations are unchanged.

Security

  • Rejected network values, secret-bearing configuration values, malformed content, and unsupported fields are asserted never to be reflected in user-facing messages.
  • Deploy remediation tests assert no plan is resolved and no subprocess is started on invalid or missing configuration.
  • The configuration reference examples are verified to contain no secret material and to state the no-implicit-Mainnet-default boundary.

Closes #182
Closes #183
Closes #184
Closes #185

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 40e01db1-551c-4051-a3c4-d6ec591df9f4
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dDevAhmed
dDevAhmed merged commit f560782 into DigiNodes:main Oct 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants