Repository navigation
test(deploy,config): add deploy network rejection, remediation, reference, and secret non-reflection suites - #248
Merged
dDevAhmed merged 1 commit intoOct 18, 2026
Conversation
…nd secret non-reflection suites Closes DigiNodes#182 Closes DigiNodes#183 Closes DigiNodes#184 Closes DigiNodes#185
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the SW-082, SW-083, SW-084, and SW-085 verification suites:
main/local/public/futurenet, empty) is rejected with the exact MVP message, the CLI path rejects before any subprocess starts, and the rejected value is never echoed;jsonexample indocs/reference/configuration.mdparses and validates against the schema, uses only supported fields, contains no secret material, and the documented precedence example is honoured by the resolver;No production code paths are changed; the suites lock down existing, documented behavior.
Testing
npm test(Vitest) — new suites live undertests/:deploy-network-rejection.test.ts,deploy-missing-config-remediation.test.ts,configuration-reference-examples.test.ts,configuration-secret-reflection.test.ts.npm run typecheck,npm run lint, andnpm run format:checkexpectations are unchanged.Security
Closes #182
Closes #183
Closes #184
Closes #185