Skip to content

test: empty existing destination behavior (#139) - #260

Merged
dDevAhmed merged 1 commit into
DigiNodes:mainfrom
samkay1277:test/139-empty-destination-behavior
Oct 18, 2026
Merged

dDevAhmed merged 1 commit into
DigiNodes:mainfrom
samkay1277:test/139-empty-destination-behavior

Conversation

@samkay1277

Copy link
Copy Markdown
Contributor

Summary

Closes #139 (SW-037).

Locks destination policy in planProjectDestination:

  • existing empty directory → allowed
  • hidden or nested content → non-empty → refused (no overwrite)
  • no force/overwrite path introduced

Acceptance criteria

  • Empty destination behavior explicit
  • Hidden/nested content treated as non-empty
  • No force/overwrite behavior
  • Repository checks (npm test) expected to pass

Test plan

npm test -- tests/project-validation.test.ts

@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8c09fd13-4d74-4891-964b-c58f55f99430
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dDevAhmed
dDevAhmed merged commit 5dc56e5 into DigiNodes:main Oct 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SW-037 — Add empty existing destination behavior tests

2 participants