Skip to content

security(codeowners): audit protected surfaces and add missing ownership entries - #272

Merged
dDevAhmed merged 1 commit into
DigiNodes:mainfrom
jbeloved700:security/issue-122-sw-107-codeowners-protected-surface-audit
Oct 18, 2026
Merged

dDevAhmed merged 1 commit into
DigiNodes:mainfrom
jbeloved700:security/issue-122-sw-107-codeowners-protected-surface-audit

Conversation

@jbeloved700

Copy link
Copy Markdown
Contributor

Summary

Audits .github/CODEOWNERS against the frozen protected-surface list in docs/contributing/wave-architecture.md and adds all missing ownership entries.

What was implemented

The following protected surfaces defined in wave-architecture.md were missing from CODEOWNERS and have been added:

  • docs/architecture/ — full directory (previously only individual files were listed)
  • docs/adr/ — full directory (previously only ADR-0003 and ADR-0004 were listed individually)
  • docs/roadmap/v1-readiness.md — v1 readiness roadmap
  • src/cli.ts, src/main.ts, src/version.ts — CLI entry-point surface
  • src/commands/root.ts — root command contract
  • src/config/ — project configuration module
  • src/process/ — process execution module
  • src/deployment/ — deployment module
  • src/generator/validation.ts — path/traversal validation
  • src/generator/template-generation.ts — filesystem write surface
  • src/generator/template-registry.ts — controlled template contract
  • src/generator/template-sources.ts — controlled template contract
  • src/dev/orchestrator.ts — dev orchestration
  • src/dev/environment.ts — environment handling

docs/contributing/ownership.md has been updated to stay aligned with the expanded coverage and to explicitly document which paths remain open contributor zones (tests/, templates/, general docs/, src/diagnostics/, src/testing/, src/commands/ except root.ts).

Acceptance criteria verified

  • Every frozen protected path has an intentional ownership decision ✅
  • Contributor-friendly paths (tests/, templates/, general docs/) are not locked down ✅
  • CODEOWNERS syntax is valid ✅
  • Ownership documentation is aligned ✅

Closes #122

…hip entries

Add ownership entries for all frozen protected surfaces defined in
docs/contributing/wave-architecture.md that were missing from
.github/CODEOWNERS:

- docs/architecture/ and docs/adr/ (full directories, replacing the two
  individual ADR entries for coverage completeness)
- docs/roadmap/v1-readiness.md
- src/cli.ts, src/main.ts, src/version.ts (CLI entry-point surface)
- src/commands/root.ts (root command contract)
- src/config/, src/process/, src/deployment/ (trust boundary modules)
- src/generator/validation.ts, src/generator/template-generation.ts,
  src/generator/template-registry.ts, src/generator/template-sources.ts
  (generator security-sensitive surfaces)
- src/dev/orchestrator.ts, src/dev/environment.ts (dev orchestration)

Update docs/contributing/ownership.md to reflect the expanded boundary
and explicitly document which paths remain open contributor zones.

No contributor-friendly paths (tests/, templates/, general docs/) are
locked down. CODEOWNERS syntax remains valid.
@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9eebc1b3-d2e4-4d59-a07e-e02141c8b4da
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dDevAhmed
dDevAhmed merged commit 5438144 into DigiNodes:main Oct 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SW-107 — Audit CODEOWNERS coverage against frozen protected surfaces

2 participants