Repository navigation
test(security): align Dependency Review policy and conformance checks - #275
Merged
dDevAhmed merged 1 commit intoOct 19, 2026
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the Dependency Review workflow contract explicit in the dependency policy and adds a focused static conformance suite. The actual workflow already matches the intended high-severity security gate; no workflow change is needed or included.
Related Issue
Closes #124
Scope
Testing
The actual branch is blocked by pre-existing repository errors. At base
dec3374008bcec02b58ca91b9a417866686b19c6,npm ci --ignore-scripts --no-audit --no-fundfails with EJSONPARSE: theaudit:workflow-permissionsentry inpackage.jsonis missing a comma. Separately,.github/workflows/ci.ymlhas an audit step outsidesteps, and a YAML parser reports errors at line 22. Neither protected file is changed by this PR.To validate this change independently, I used a separate local copy with only that missing package.json comma repaired. These are qualified results, not claims that the PR branch passes repository checks:
npm test -- tests/dependency-review-policy.test.ts tests/dependabot-policy.test.ts tests/workflow-security.test.tsgit diff --checkpasses on the contribution branch. Dependency Review YAML parses without errors; the workflow is unchanged. Repository-wide checks remain blocked and this PR is not represented as merge-ready. The isolated package repair is not committed. Please address the main-branch baseline separately, then rerun the full gates.Security Impact
Security notes: supply-chain documentation and tests only; no permission changes, threshold changes, gate bypasses, exceptions, workflow edits, auto-merge or new dependencies. Maintainer supply-chain review requested by issue scope.
Release Impact
Release notes: contributor docs/tests only, no shipped CLI behavior change.
Documentation
Checklist
docs/contributing/wave-architecture.mdfor Stellar Wave work