feat: V2 commitment replay boundary — frozen preimage, domain binding, weak salt

[GazzyLee]

Freeze commitment preimage fields, types, encoding, chain/release/contract/round domains, and salt requirements for VerificationCommitReveal (PREWAVE-SC-085).

Changes

Contract (contracts/v2/VerificationCommitReveal.sol)

• RELEASE_VERSION constant — pinned protocol release hash for cross-release replay protection
• COMMITMENT_TYPEHASH updated — includes releaseVersion and deadline (10 replay dimensions total: chainId, releaseVersion, verifyingContract, verifier, claimId, roundId, deadline, decision, rationaleHash, salt)
• Deadline parameter added to commit(),
  eveal(),
  evealWithSignature(), _reveal(), and computeCommitment() — stored in Record and must match at reveal
• Deadline validation — DeadlinePassed, DeadlineTooShort (below MIN_DEADLINE_BUFFER=1h), DeadlineTooFar (above MAX_DEADLINE_HORIZON=365 days)
• Weak salt detection — WeakSalt error for all-identical bytes, last-byte-only non-zero, and small integer-like salts
• Encoding — all preimages use �bi.encode (never �bi.encodePacked)
• New errors: WeakSalt, DeadlinePassed, DeadlineTooShort, DeadlineTooFar

Tests ( est/v2/VerificationCommitReveal.t.sol)

• Cross-chain replay (chainId 10 vs 1)
• Cross-release replay (canonical vs alt release version)
• Cross-contract replay (same hash on different contract instance)
• Cross-round replay (reveal on wrong round)
• Field reordering (swapped fields produce different hash)
• Packed encoding ambiguity demonstration
• Zero salt, weak salt (all-identical, last-byte-only, small-int)
• Wrong voter
• Deadline validation (past, too soon, too far, min buffer, max horizon)
• Fuzz: any changed field fails and leaves state intact
• Fuzz: weak salt is rejected

Infrastructure (build fixes)

• config/networks.ts — missing module required by hardhat.config.ts

emappings.txt — point to node_modules instead of empty lib/ submodules

• V2OperationIds.sol, V2SubmoduleProvenance.sol — missing stubs for compilation

Acceptance Criteria

• Commitments are unambiguous and context-bound (10-dimensional domain separation)
• Published vectors match on/off-chain implementations (computeCommitment is public view)
• Reveal cannot be replayed elsewhere (cross-chain/release/contract/round all fail closed)
• Pre-reveal data exposes no decision (only commitment hash emitted)

Security & Architecture Constraints

• Preserves approved Optimism/EVM V2 topology, timelock, role, and operation-scoped pause model
• Does not weaken tests, assertions, custom errors, or release gates (additive only)
• Uses exact integer arithmetic and deterministic artifacts

Dependencies

• PREWAVE-SC-003 — Fuzz Commit-Reveal Privacy, Deadlines, and Replay Domains #678
• PREWAVE-SC-013 — Restore Canonical Verification-Intent EIP-712 Constants #689

Non-Goals

• Unrelated refactors or mainnet deployment
• Applying Stellar Wave before maintainer activation

Closes #719

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: Repository: DigiNodes/truthbounty-contract/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 66080b3b-9f46-44e7-9d6f-a1fb71993e87

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}