Use config file to set unselected annot opacity - #543
Merged
Conversation
naglepuff
force-pushed
the
mln/unfocused-annotation-opacity-setting
branch
from
August 10, 2026 21:30
8e2919d to
4900f05
Compare
naglepuff
force-pushed
the
mln/unfocused-annotation-opacity-setting
branch
from
August 10, 2026 21:59
4900f05 to
7572019
Compare
naglepuff
marked this pull request as ready for review
August 11, 2026 14:00
Contributor
|
Testing now -- can you add this to the docs here: https://github.com/DigitalSlideArchive/HistomicsUI/blob/master/docs/config_options.rst |
manthey
approved these changes
Aug 11, 2026
manthey
left a comment
manthey
left a comment
Contributor
There was a problem hiding this comment.
We can add the new config setting to the docs as part of this PR or as a follow on PR.
Contributor
Author
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #541
Previously, non-selected annotation elements had their opacity reduced by multiplying by
0.25. This reduction was hard-coded behavior in thegirder_large_image_annotationimage viewer widget.Accompanying changes to the
girder_large_image_annotationplugin allow passing in a custom opacity multiplier.The changes in this PR read a key/value pair with the key
unselectedOpacityMultiplierfrom the.histomicsui_config.yamlitem and pass that value to the image viewer widget.