Repository navigation
fix(cli): honor STELLAR_CONFIG_HOME and STELLAR_HOME in identity export/import - #303
Merged
Merged
Conversation
…rt/import defaultStellarHome() now respects STELLAR_CONFIG_HOME > STELLAR_HOME > XDG_CONFIG_HOME/stellar > ~/.config/stellar, matching stellar-cli resolution. Fixes export shipping the wrong dir and import restoring where stellar-cli won't look when STELLAR_HOME is set.
|
@VeronicDev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Add a patch changeset for @caatinga/cli. - Say which env vars stellar-cli reads instead of "matching stellar-cli". - Show the env precedence in `identity import --help` and use `<dir>` in the docs headings. - Remove the temporary STELLAR_HOME in a finally block in the test.
Dione-b
force-pushed
the
fix/identity-stellar-home-233
branch
from
October 20, 2026 17:20
6e6df70 to
9dacac7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #233
Motivation
defaultStellarHome()always returned~/.config/stellardespite help text claimingSTELLAR_HOMEsupport. WithSTELLAR_HOME=/secure/mainnet-keys, export shipped the wrong dir and import restored where stellar-cli won't look.Behavior
defaultStellarHome()now respectsSTELLAR_CONFIG_HOME > STELLAR_HOME > XDG_CONFIG_HOME/stellar > ~/.config/stellar, matching stellar-cli resolution (--config-dir>STELLAR_CONFIG_HOME>XDG_CONFIG_HOME/stellar> default).exportandimport --pathdefaults use it.docs/cli.md.Tests
identity.command.test.ts(defaultStellarHome env precedence (#233)): fallback, STELLAR_HOME, STELLAR_CONFIG_HOME, precedence, XDG, empty handling, and export-without---path e2e.identity.command.test.ts: 14 passedidentity.ci-restore.test.ts: 3 passed@caatinga/cli: 38 files, 252 tests passed,typecheckclean.Release impact
defaultStellarHome).