Repository navigation
test(cli): cover zk build --network target resolution - #310
Merged
Merged
Conversation
Port the remaining useful cases from #252: an explicit `--network mainnet` is allowed with `--allow-dev-ceremony`, and omitting `--network` resolves to defaultNetwork. The blocked-mainnet and unknown-network cases from #252 were already covered on main. Co-authored-by: AugistineCreates <project.kosiso@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#252 (by @AugistineCreates) added
--networktoctg zk build; main shipped the same fix in #304/#305, so #252 was closed as superseded. This ports the tests from it that main didn't already have, with credit.Behavior
Tests only, no production changes. Two new cases in
packages/cli/src/commands/zk-build.command.test.ts:--network mainnet --allow-dev-ceremonyis allowed (buildCircuitruns).--networkfalls back todefaultNetwork(logsNetwork: testnet (config)).#252's blocked-on-mainnet and unknown-network (
CAATINGA_NETWORK_NOT_FOUND) cases were already covered on main, so I didn't duplicate them.Tests
pnpm --filter @caatinga/cli test: 41 files / 301 tests passpnpm typecheck,pnpm format: cleanRelease impact
None (tests only, no changeset).
Co-authored-by: AugistineCreates project.kosiso@gmail.com
🤖 Generated with Claude Code