Skip to content

Fix/pagination theme colors - #1479

Closed
onyekachi66 wants to merge 3 commits into
Disciplr-Org:mainfrom
onyekachi66:fix/pagination-theme-colors
Closed

onyekachi66 wants to merge 3 commits into
Disciplr-Org:mainfrom
onyekachi66:fix/pagination-theme-colors

Conversation

@onyekachi66

Copy link
Copy Markdown
Contributor

Closes #1222

Description

What does this PR do?
This PR resolves a styling issue where the Pagination component was hardcoding raw hex colors (#121a2a and #00c389) directly in its Tailwind classes instead of utilizing the application's standard CSS custom properties. By replacing these hardcoded values with design tokens, the component now properly responds to the app's light/dark theme toggle alongside the rest of the component library.

Key Changes:

  • Replaced bg-[#121a2a] and text-white with bg-[var(--bg)] and text-[var(--text)] on the Previous button.
  • Replaced bg-[#00c389] and text-[#121a2a] with bg-[var(--accent)] and text-[var(--bg)] for the Current page indicator and the Next button.
  • Adjusted the default inactive page styles to use bg-[var(--surface)] and text-[var(--text)].

Testing Instructions:

  • Navigate to paginated screens (such as ValidationHistory or Notification).
  • Verify that the Pagination component correctly displays the intended colors for both light and dark mode when toggling themes.

@drips-wave

drips-wave Bot commented Oct 1, 2026

Copy link
Copy Markdown

@onyekachi66 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace hardcoded hex colors with design tokens in Pagination.tsx

2 participants