Repository navigation
Fix NotificationSettings failure paths and boundary coverage - #1480
Closed
AugistineCreates wants to merge 1 commit into
Closed
AugistineCreates wants to merge 1 commit into
AugistineCreates wants to merge 1 commit into
Conversation
|
@AugistineCreates Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1296
Summary
Implements deterministic failure paths and corrects broken boundaries in
src/pages/NotificationSettings.tsx.Why this matters
The
NotificationSettingscomponent previously had unfinished implementations for a time range (start/end) which triggered reference errors and bypassed the single time value validation tests. This could lead to a crash on the client when interacting with the form. Fixing this ensures determinism and alignment with the test suite.Changes
quietStartValue/quietEndValuestate references that caused reference errors.Quiet Hours<input>mapped properly toisValidQuietTime, ensuringaria-invalidbehaves as expected.isValidQuietHoursRange,isQuietHoursActive) and un-exported destructured parameters (quietHoursRange) fromuseNotificationPreferences.Acceptance Criteria Addressed