Repository navigation
Remove dead exports notificationTypeIcons and notificationTypeColors from example.ts - #1485
Closed
Opulencechuks wants to merge 2 commits into
Closed
Opulencechuks wants to merge 2 commits into
Opulencechuks wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1219
Summary
This PR removes the
notificationTypeIconsandnotificationTypeColorsdead exports fromsrc/components/Notification/exampleNotification/example.ts.Details
These simple mappings duplicated the canonical
NOTIFICATION_TYPE_MAPalready maintained insrc/components/Notification/notificationType.ts, but utilized non-token color values (like "grey", "orange", "red", "amber", "blue") rather than real hex values with accessible labels. Since these exports were never imported anywhere outside their own definition file, they were fully dead exports that created a risk of a future contributor unintentionally using them instead of the canonical map.Both dead exports (and their corresponding unused
react-iconsimports) have been safely deleted to eliminate this drift risk. The actively usedgetNotifications()andvaultsexports remain untouched.