Skip to content

No event on early lease termination #1492

Closed

Description

@yusuftomilola

contracts/assetsup/lease.rs appears to emit an event on normal lease expiry but not when a lease is terminated early.

Activity

  1. rupesh-kumar-sah commented on Sep 30, 2026

    @rupesh-kumar-sah

    Hi everyone,

    I am interested in working on this issue.
    Plan:

    1. Deliver a clean, well-tested implementation for No event on early lease termination following DistinctCodes/AssetsUp conventions.
    2. Ensure the change passes all existing lint, format, and CI verification pipelines.

    I am ready to start immediately—please feel free to assign this to me!

  2. Johnsource-hub commented on Sep 30, 2026

    @Johnsource-hub

    📋 Grainlify Application

    @Johnsource-hub has applied to work on this issue as part of the Grainlify program.

    assign me to work on this issue


    Repo Maintainers: To accept this application, review their application or assign @Johnsource-hub to this issue.

  3. Douglas366 commented on Oct 2, 2026

    @Douglas366

    📋 Grainlify Application

    @Douglas366 has applied to work on this issue as part of the Grainlify program.

    Hello Maintainers,
    I’m experienced in frontend, backend, and Web3 development. I’m interested in contributing to this project and would be happy to help improve its existing functionality.


    Repo Maintainers: To accept this application, review their application or assign @Douglas366 to this issue.

  4. Danivoxdev commented on Oct 16, 2026

    @Danivoxdev

    @Danivoxdev has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I would like to work on this issue because it is a clear opportunity to improve the consistency of lease lifecycle event handling in AssetsUp. I will investigate how contracts/assetsup/lease.rs handles normal lease expiration and early termination, identify why the expected event is not emitted when a lease is terminated early, and implement a fix that follows the existing event-handling patterns.

    I will also add or update tests to cover early lease termination and normal lease expiration, ensuring the correct events are emitted in both cases without introducing regressions. I will keep the changes focused, follow the project's coding conventions, and verify the solution with the relevant test suite before submitting a clean pull request.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Danivoxdev to this issue.

  5. limxiy commented on Oct 16, 2026

    @limxiy
    Contributor

    @limxiy has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Can I please work on this issue?

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @limxiy to this issue.

  6. drips-wave commented on Oct 16, 2026

    @drips-wave

    Congratulations, @limxiy! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @limxiy: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  7. grantfox-oss commented on Oct 17, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @limxiy's PR #1686 was approved and merged by @yusuftomilola.

    🏆 @limxiy: You earned 40 FoxPoints for this contribution! Your current tier: Builder (1,708 total points). Track your full progress on GrantFox.

    👏 Great work, @limxiy! Keep contributing to DistinctCodes.

  8. drips-wave commented on Oct 17, 2026

    @drips-wave

    This issue has been completed by @limxiy as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @limxiy: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

  9. added a commit that references this issue on Oct 17, 2026
    83e5f87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programbugSomething isn't workingcontract

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions