Skip to content

Database environment variable names and defaults disagree between app, compose, CI and docs #1575

Closed

Description

@yusuftomilola

Problem

The same settings are spelled and defaulted differently across files:

  • app.module.ts reads DB_DATABASE (default manage_assets, password default password).
  • data-source.ts reads DB_DATABASE (default assetsup, password default postgres).
  • docker-compose.yml and backend-ci.yml set DB_NAME (assetsup_dev / assetsup_test) with password postgrespassword.
  • .env.example uses DB_DATABASE=assetsup, DB_PASSWORD=postgres.
    So the app, the TypeORM CLI and CI can each talk to a different database, and CI's DB_NAME is never read.

Proposed change

Standardise on one set of names, read them through a single shared config helper used by both AppModule and data-source.ts, and update compose/CI/.env.example/README accordingly.

Acceptance criteria

  • One source of defaults; no env var is set anywhere that the code never reads.

Activity

  1. hauwauyahass-byte commented on Oct 16, 2026

    @hauwauyahass-byte

    @hauwauyahass-byte has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I'd be glad to handle this issue. I'll keep the implementation concise, maintainable, and well-documented.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @hauwauyahass-byte to this issue.

  2. portableDD commented on Oct 16, 2026

    @portableDD
    Contributor

    @portableDD has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi, I'd like to take this on.

    I've worked on blockchain and Web3 projects, including Stellar and Soroban smart contracts, alongside traditional full-stack web development. I'm comfortable moving between frontend, backend, and on-chain work.

    I've reviewed the issue and I'm confident I can implement a solid solution while following the project's conventions.

    Happy to get started right away if assigned — looking forward to contributing.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @portableDD to this issue.

  3. drips-wave commented on Oct 16, 2026

    @drips-wave

    Congratulations, @portableDD! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @portableDD: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  4. grantfox-oss commented on Oct 17, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @portableDD's PR #1675 was approved and merged by @yusuftomilola.

    🏆 @portableDD: You earned 40 FoxPoints for this contribution! Your current tier: Builder (2,348 total points). Track your full progress on GrantFox.

    👏 Great work, @portableDD! Keep contributing to DistinctCodes.

  5. drips-wave commented on Oct 17, 2026

    @drips-wave

    This issue has been completed by @portableDD as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @portableDD: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programbackendbugSomething isn't workingdevopsCI/CD, infrastructure, and deployment

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions