Repository navigation
feat(api): dept/vendor asset lists, asset QR and label - #1676
Merged
yusuftomilola merged 2 commits intoOct 17, 2026
Merged
yusuftomilola merged 2 commits into
yusuftomilola merged 2 commits into
Conversation
|
@TomikeDS is attempting to deploy a commit to the naijabuz's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@TomikeDS Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1595
Closes #1594
Closes #1593
Closes #1592
Summary
GET /departments/:id/assets(bydepartmentId),GET /departments/:id/users(non-sensitive columns only; no hash or token fields are selected) andGET /vendors/:id/assets(bysupplierId). All sit behind the existingJwtAuthGuard, return the standard{items,total,page,limit,totalPages}shape, and 404 for an unknown department/vendor. Specs cover populated, empty and 404 cases.GET /assets/:id/qr(format=png|svg,size64-1024) encoding${FRONTEND_URL}/assets/:id, andGET /assets/:id/label, a Code 128 barcode PNG of the asset tag viabwip-js. Both are JWT-guarded, return the correctContent-Type, and 404 for an unknown asset. Uses the already-installedqrcodeandbwip-js.fileSizeBytesfield #1592 are not implemented in this PR; only 2 of the 4 assigned issues are addressed.Note: the frontend
getVendorAssetsis typed asunknown[]but now receives the paginated object; it should read.items.Linked issues
Closes #1595, #1594, #1593, #1592 (see top of description)
Checks
.envvalues are committedNot run: dependencies were not installed in this workflow, so lint, build and tests were not executed. The scan URL path (
/assets/:id) assumes the frontend route; #1596 adds a dedicated scan endpoint that this could later point to.