Skip to content

fix(assets): bounded sorted lists, escaped search, trigram index - #1678

Merged
yusuftomilola merged 2 commits into
DistinctCodes:mainfrom
amberly-d:fix/amberlyd-pagination-search-escape-1584-1585
Oct 17, 2026
Merged

yusuftomilola merged 2 commits into
DistinctCodes:mainfrom
amberly-d:fix/amberlyd-pagination-search-escape-1584-1585

Conversation

@amberly-d

Copy link
Copy Markdown
Contributor

Closes #1587
Closes #1586
Closes #1585
Closes #1584

Summary

Behaviour change to note: invalid limit/sortBy/role values on GET /assets and GET /users now return 400 instead of being ignored. Other list endpoints (departments, vendors etc.) already use PaginationQueryDto.

Linked issues

Closes #1587, #1586, #1585, #1584 (see top of description)

Checks

  • Lint passes for every area touched
  • Build passes
  • Tests pass
  • No secrets, keys, or .env values are committed

Not run: dependencies were not installed in this workflow, so lint, build and tests were not executed. The migration and the EXPLAIN acceptance criterion were not run against a database. The pg_trgm extension needs a role allowed to create extensions.

@vercel

vercel Bot commented Oct 16, 2026

Copy link
Copy Markdown

@amberly-d is attempting to deploy a commit to the naijabuz's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Oct 16, 2026

Copy link
Copy Markdown

@amberly-d Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@yusuftomilola
yusuftomilola merged commit 36b1067 into DistinctCodes:main Oct 17, 2026
0 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants