Repository navigation
Fix WebSocket port, depreciation mock, reservations and notifications mock data - #1689
Merged
yusuftomilola merged 6 commits intoOct 17, 2026
Conversation
|
@devzakari-sketch is attempting to deploy a commit to the naijabuz's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@devzakari-sketch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses four frontend issues with small, focused changes:
#1627 - useWebSocket defaults to port 8000 instead of 6003
hooks/useWebSocket.tsto derive the default WebSocket URL fromNEXT_PUBLIC_API_URLinstead of hardcoding port 8000.authoption for authenticated connections.#1614 - DepreciationSchedule renders mock data instead of real schedule
components/assets/depreciation-schedule.tsxto accept anassetIdprop and fetch real data fromGET /assets/:id/depreciationvia the API client.MOCK_DATAand added loading, error, and "no depreciation configured" states.#1613 - Reservations page uses mock data
lib/api/reservations.tswith a typed API client (list mine/all, create, cancel, confirm, availability).reservations/page.tsxto load reservations from the API instead ofMOCK, with loading and empty states.#1612 - Notifications page renders hard-coded mock data
lib/api/notifications.tswith a typed API client (list, unread count, mark read, mark all read).notifications/page.tsxto load from the API, with loading, error, and empty states; removedMOCK_NOTIFICATIONS.Closes #1627
Closes #1614
Closes #1613
Closes #1612