Repository navigation
fix(mcp): return empty search results as successful collection instead of error (#414) - #562
Open
sparkysolutions10-pixel wants to merge 1 commit into
Conversation
sparkysolutions10-pixel
force-pushed
the
fix/mcp-empty-search-success-414
branch
from
October 19, 2026 17:52
cd30481 to
af57a89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #414
Returns empty search results as a successful collection response (
{ resources: [], count: 0 }) instead of reporting it as an error (ERR_NO_RESULTS), distinguishing empty matches from actual service errors.Changes
bazaar_searchhandler insrc/mcp/server.tsso zero-length match results return{ resources: [], count: 0 }with successful status (isError: false/ omitted).examples/mcp-server/README.mdto document that empty searches yield{ resources: [], count: 0 }rather thanERR_NO_RESULTS.Tests
tests/mcp.test.ts:returns success with empty collection when bazaar_search finds no resources (#414)returns success with empty collection when endpoint returns empty array (#414)npx vitest run tests/mcp.test.ts).