Repository navigation
feat(admin): list API keys with pagination and revoked filter (#505) - #569
Open
sparkysolutions10-pixel wants to merge 1 commit into
Open
sparkysolutions10-pixel wants to merge 1 commit into
sparkysolutions10-pixel wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #505.
Summary of Changes
The admin surface allowed minting a key and revoking a key by ID, but provided no way to list existing keys. Operators who did not capture the ID at mint time were unable to identify or revoke keys through the API.
This PR implements
GET /admin/keysaccording to all issue requirements:GET /admin/keys):isAdminAuthorized(), returning 401 on unauthorized attempts.hashand plaintext from the Prisma query select and JSON response. Onlyid,label, quotas,createdAt,revokedAt, andexpiresAtare exposed.where: { revokedAt: null }) to reflect currently live keys.includeRevoked=true.limit(default 50, capped at 100) andoffset(default 0), returning{ keys, total, limit, offset, hasMore }.src/__tests__/adminListKeys.test.tsverifying 401 unauthenticated responses, non-revoked default filtering, pagination parameters, and explicit assertion thathashis absent from the response body.Testing
npx vitest run src/__tests__/adminListKeys.test.ts(3/3 passed)npx vitest run tests/openapi.test.ts(8/8 passed)