Repository navigation
feat(auth): record and throttle key lastUsedAt on successful authentication (#500) - #570
Open
sparkysolutions10-pixel wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #500.
Summary of Changes
Operators inspecting API keys previously had no visibility into which keys were still actively in use versus stale and safe to revoke. Updating the database on every authenticated request would turn a high-throughput read-only auth check into a write amplifier.
This PR implements
lastUsedAttracking with robust rate throttling and admin visibility:lastUsedAt DateTime? @map("last_used_at")toApiKeyinprisma/schema.prisma.recordKeyLastUsed) insrc/api/auth.ts.lastUsedAtat most once per throttle window per key.API_KEY_LAST_USED_THROTTLE_SECONDS(default: 60s), documented in.env.example.lastUsedAtinPOST /admin/keysandGET /admin/keysso operators can inspect key activity.src/__tests__/keyLastUsedAt.test.tsverifyinglastUsedAtrecording, throttle enforcement across 10 repeated requests, configurable intervals, and visibility onGET /admin/keys.Testing
npx vitest run src/__tests__/keyLastUsedAt.test.ts(4/4 passed)npx vitest run src/__tests__/auth.test.ts(22/22 passed)npx vitest run tests/openapi.test.ts(8/8 passed)