Repository navigation
feat(events): add transactional booking outbox - #171
Open
fredericklamar342-prog wants to merge 2 commits into
Open
fredericklamar342-prog wants to merge 2 commits into
fredericklamar342-prog wants to merge 2 commits into
Conversation
|
@fredericklamar342-prog Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appointment.bookedis the first event producer.FOR UPDATE SKIP LOCKED, lease stale claims, and apply bounded exponential retries with dead-lettering after five attempts.Shared prerequisite
This branch includes the notification inbox implementation from PR #167, which is required for the booking notification handler. Please merge #167 first. After it lands, this branch may need rebasing to remove the shared prerequisite commit from this PR's diff.
Tests
Passed locally:
npm run prisma:generatenpm run audit:prodnpm run typechecknpm test(96 passed)npm run test:integration(171 passed)npm run buildThe broad
npm run test:allcommand also includes the separate live-testnet payments suite; its setup fails when its external-network tests are skipped. The CI workflow uses the unit and self-contained integration commands listed above and does not include that directory.Architecture and migration
Adds
OutboxEventand a nullable uniqueNotification.sourceEventIdfield. Apply the new Prisma migration with the normal migration deploy process. Events are at-least-once; handlers must remain idempotent. Dead-letter responses omit payloads and expose only stable error codes and event metadata.Closes #94