Repository navigation
ci: load workflow scripts as .cjs (fixes notifier/scan under "type": "module") - #180
Merged
Merged
Conversation
docforum-web's package.json sets "type": "module", so Node loaded .github/scripts/*.js as ES modules and both workflows failed with "module is not defined in ES module scope". .cjs is always CommonJS regardless of package.json, so the scripts work in every repo. Renamed in all three repos to keep them identical. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Malware scan: passed, with notes for the reviewerNothing malicious was detected in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Renames
.github/scripts/pr-conflict-notifier.jsand.github/scripts/pr-malware-scan.jsto.cjs, and updates the two workflows andROADMAP.mdto match.Why
docforum-web'spackage.jsonhas"type": "module", so Node treated the.jsscripts as ES modules. Both workflows failed there withReferenceError: module is not defined in ES module scope(the first conflict-notifier runs on webmainfailed this way).Malware scanis now a required check, so every web PR push would have been blocked..cjsis always CommonJS whateverpackage.jsonsays, so the scripts are renamed in all three repos to keep them identical and future-proof.Testing
package.jsonhas"type": "module",require()of the old.jsfails, and both.cjsfiles load.Which ROADMAP.md item does this close/progress?
Updates the file paths in the existing notifier and malware-scan items.
🤖 Generated with Claude Code