Repository navigation
fix(ci): retry transient GitHub API errors in PR automation - #198
Merged
Merged
Conversation
Malware scan: passed, with notes for the reviewerNothing malicious was detected in
|
|
@afeezorobsco-cyber This PR now has merge conflicts with git fetch upstream # upstream = https://github.com/DocForum/docforum-core.git
git rebase upstream/main
# resolve the conflicts, re-run the tests, then:
git push --force-with-leaseThe usual culprits are shared files like Automated message. It won't repeat unless the PR conflicts again after your next push. |
A single 500/503 from the GitHub API aborted the whole conflict-notifier run, so the PRs after it were never labelled or notified. Set `retries: 3` on actions/github-script in pr-conflict-notifier.yml and pr-malware-scan.yml so 5xx responses are retried, and isolate each PR in the notifier: a PR whose calls still fail is logged as a warning and picked up on the next run, while the others are processed normally. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
afeezorobsco-cyber
force-pushed
the
fix/automation-api-retries
branch
from
October 20, 2026 15:24
ee830de to
cf2dc19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today the conflict notifier failed three times on transient GitHub errors (web:
503onGET /pulls/161, then500onPOST /issues/189/labels; escrow:500onPOST /issues/160/comments). Each failure aborted the whole run, so PRs after the failing one weren't labelled or notified until a manual re-run.pr-conflict-notifier.ymlandpr-malware-scan.yml:retries: 3onactions/github-script. The built-in Octokit retry plugin then retries 5xx responses; 4xx are never retried.pr-conflict-notifier.cjs: each PR is processed in its owntry/catch. A PR whose calls still fail is logged withcore.warningand listed under "API error, retried next run" in the run summary, and the rest carry on. The mergeability prefetch usesPromise.allSettled.The malware scan runs as
pull_request_target, so its retry setting takes effect once this is onmain.Tested with a fake client that returns a 500 on one PR's
addLabels: the other PRs were still notified and unlabelled, and the failing PR was reported under the new summary line.🤖 Generated with Claude Code