Skip to content

Fixed player falling through collisions - #2167

Open
dldev32 wants to merge 4 commits into
DonBruce64:masterfrom
dldev32:collision-fixes
Open

dldev32 wants to merge 4 commits into
DonBruce64:masterfrom
dldev32:collision-fixes

Conversation

@dldev32

@dldev32 dldev32 commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@DonBruce64

Copy link
Copy Markdown
Owner

@SnailPerson I'm assuming this works for you mo betta?

@SnailPerson

Copy link
Copy Markdown
Contributor

@DonBruce64 baseline works, but no merge yet, im still investigating if it has the typical mts side effects (random unrelated shit breaks for some reason)

@DonBruce64

Copy link
Copy Markdown
Owner

Very well could be. Though I will say that this does at least limit things to just entities and not vehicles. One issue could be the classic shoving things into the ground that got fixed that could come back up. Also potentially how moving entities and jumping on things. Cause sometimes you couldn't jump on vehicles since they would drag you back to them. Least those are things I noticed as bugs back when fixing collision issues in the past.

@LauraDarkez

LauraDarkez commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

in my testing of 1.12.2, i have not noticed any issues with not being able to jump. there are occasional issues of getting stuck in the hitbox in a way that stops you from walking in some circumstances, but you can at least jump still and that often helps dislodge you. plus, the function of being able to ride moving objects has been returned, which in my opinion is great

Minecraft.1.12.2.2026-09-10.08-18-44.mp4

mobs also can walk on these hitboxes, meaning i wont need to worry about my pets falling under the floor of my camper beds when trying to get them inside the camper

@DonBruce64

Copy link
Copy Markdown
Owner

@LauraDarkez thanks! Good data. @SnailPerson you good to merge? If so, I'll call this good. Seeing the doors work is a really nice touch.

@dldev32

dldev32 commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

@LauraDarkez thanks! Good data. @SnailPerson you good to merge? If so, I'll call this good. Seeing the doors work is a really nice touch.

Hold on a bit; I haven't fixed the collision movement issue for 1.12.2 yet.

@DonBruce64

Copy link
Copy Markdown
Owner

Rodger that.

@dldev32

dldev32 commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Rodger that.

Done.

@DonBruce64

Copy link
Copy Markdown
Owner

@LauraDarkez ready for cross-checking.

@SnailPerson

SnailPerson commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

im watching this. So far, looks VERY promising.
Will give merge confirm once I ran another final test on my end, gonna wait for @dldev32 to send me a beta on discord to test with. Till then, doing icons for scanner

@LauraDarkez

Copy link
Copy Markdown
Contributor

i confirm that 1.12.2 is working beautifully, but yes, snail should go ahead and test newer than 1.12 versions pls

@SnailPerson

Copy link
Copy Markdown
Contributor

@DonBruce64 no apparent flaws in here, mobs dont get to you much as they used to anymore so thats good

Bildschirmaufnahme.2026-09-13.um.01.51.mp4

Only thin hitboxes seem to be affected by some jittering

@DonBruce64

Copy link
Copy Markdown
Owner

@SnailPerson I'd say it's probably good enough. @dldev32 do you wanna poke those thin boxes or merge as-is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants