Repository navigation
Add a firmware update screen with install, progress and pre-checks - #112
Draft
virtitnerd wants to merge 1 commit into
Draft
virtitnerd wants to merge 1 commit into
virtitnerd wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: Python-roborock/local_roborock_server#255
Why
The update check existed but was hidden, because a robot paired to the local server could not be updated at all. With the
server able to install, LocalRock can do it too.
What
A Firmware updates row in the robot settings opens a screen that checks for an update and shows the installed and
available versions with the release notes. Update now asks the server to install, then follows the robot through
download, install and reboot using its own
get_ota_stateandget_ota_progress, including the minute it is offline.The same rule as the server decides if the button works, and the screen says why it does not: docked (or asleep on its
charger), not cleaning, no error, at least 80% battery.
Testing
Unit tests for the pre-check and for the progress steps. The screen was opened on a Qrevo Curv 2 Flow after its real
update, where it reads Up to date with the installed version. The install path itself has not been run from LocalRock yet,
because that robot is already current. The same update through the official app's Update button is what the server PR
was verified with.