Skip to content

Match the official app: Maintenance, feature bits, carpet modes and robot settings - #117

Open
virtitnerd wants to merge 12 commits into
DonSidro:masterfrom
virtitnerd:pr2/parity-fixes
Open

virtitnerd wants to merge 12 commits into
DonSidro:masterfrom
virtitnerd:pr2/parity-fixes

Conversation

@virtitnerd

Copy link
Copy Markdown
Contributor

A set of smaller fixes and settings that bring LocalRock in line with the official app. It replaces #104 and #105 and adds the fixes and robot settings that came after them, so they can be reviewed as one. Each commit stands on its own.

Depends on nothing; based on master.

What's in it

  • Maintenance screen. strainer_work_times and cleaning_brush_work_times count runs, not seconds, so the cleaning tray always showed about 100%; they are now measured out of 150 and 300 runs, as in the official app. Strainer is renamed Cleaning Tray. Sensors and the tray show Normal, Clean soon or Must clean instead of hours, percentages round up and the colour steps follow the official app. Mop and Dust Bag read "Replace as needed." with no bar.
  • Advertised feature bits. The Beta page listed 11 bits on a Qrevo Pro that are not missing controls. Bits 35, 38, 41, 42, 47, 49, 51, 52, 53, 57 and 62 now count as handled (they already have controls, or name no setting).
  • Carpet modes. set_carpet_clean_mode takes 0 avoid, 1 rise (vacuum only), 2 vacuum and mop and 3 dynamic lift. The screen called 1 Standard and 2 Carpet boost, so choosing Carpet boost sent the value that mops carpets. The official names are used, mode 2 says it can wet the carpet, and dynamic lift shows when the robot is in it.
  • Drying times per model. The a244 and a245 get 3, 4 and 5 hours; other models 2, 3 and 4. A value the robot already reports outside that list stays selectable.
  • Login errors. A refused login showed a JSON decode error. The reply's code is now checked first, and a refusal becomes a plain sentence with the server's reason.
  • A docked robot is drawn at its charger. A robot carried back to its dock keeps its old map position until it re-localizes. While its state says it is charging, or emptying, washing or drying at the dock, the map draws it at the charger.
  • Robot settings by name, and Smart Charging. Newer firmware keeps many on/off options behind app_get_robot_setting and app_set_robot_setting, picked by name. This adds the uncleaned area reminder, follow low obstacles, full duplex voice, climbing arms on high thresholds and Smart Charging (bit 74).
  • Carpet border wire and side brush lowering switches (bits 105 and 104).
  • Cleaning Pattern (bit 70) as a picker on the Floor cleaning page, replacing the older floor direction toggle only once its value has been read.
  • Carpet mode actually changes on newer robots. set_carpet_clean_mode was sent as a one-item list; a Curv 2 Flow refuses that with -10005 "param is not an object", so picking a carpet mode did nothing there. It is now sent as {"carpet_clean_mode": n} like the official app, which both a Curv 2 Flow and a Qrevo Pro accept (checked live).

Replaces #104 and #105.

Notes

How it was tested

testDebugUnitTest and compileCommonMainKotlinMetadata pass on this branch, with tests for the maintenance maths (values a Qrevo Pro reports), the handled feature bits, carpet modes, drying times, the login reply, the docked robot and the robot setting parameters. The Maintenance and feature-bit changes were checked on a Qrevo Pro (a101) against the official app. The branch was also merged with every other open PR and the result built and tested.

virtitnerd and others added 12 commits November 14, 2026 21:18
Bits 41 (wash towel), 49 (carpet clean mode) and 53 (dust collection mode)
have getters and setters here already, and 35, 47 and 51 map to the fluid
delivery and custom mode controls. A Qrevo Pro answers get_wash_towel_mode,
get_carpet_clean_mode and get_dust_collection_mode, so they were reported as
uncontrolled only because no bit was attached to them.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…issing controls

Bit 42 is the get/set_clean_follow_ground_material_status pair the app already
has as Clean by floor type (the official app's own bridge maps its floor
direction call to that command). Bit 57 means the robot offers no carpet
pressure setting, and bit 38 is the cloud endpoint, not a setting.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…rols

In the official app bit 52 is only a name in its feature table, and the AI
recognition switch follows camera status. Bit 62 lowers the battery needed to
start building a map from 20% to 15%. Neither is a setting.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Percentages round up and use the app's 20% and 5% colour steps. The
cleaning tray and maintenance brush counters are run counts, not seconds,
so they are measured out of 150 and 300 runs. Sensors and the tray show a
state ("Normal", "Clean soon", "Must clean") instead of hours, and the tray
is named Cleaning Tray. Mop and Dust Bag are listed as "Replace as needed."

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
set_carpet_clean_mode takes 0 avoid, 1 rise (the mop lifts, vacuum only),
2 vacuum and mop (the mop runs over the carpet and can wet it) and 3 dynamic
lift. The settings screen called 1 Standard and 2 Carpet boost, so choosing
Carpet boost sent the value that mops carpets. Use the official names, say
that mode 2 can wet the carpet, and show dynamic lift when the robot is in it.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The a244 and a245 get 3, 4 and 5 hours; other models get 2, 3 and 4. A value the robot already reports outside that list stays selectable.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A refused login has no user data, so decoding the reply as UserData failed
before the code check ran and the sign-in page showed the serializer's
message. The reply's code is now checked first, and a refusal or an
incomplete reply becomes a plain sentence with the server's reason.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A robot carried back to its dock keeps reporting its old position in the
map until it re-localizes, so the marker stayed where it was found. While
the robot's own state says it is charging, or emptying, washing or drying
at the dock, the device page draws it at the charger. Docked is decided
from the state only: charge_status reads 1 off the dock too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Newer firmware keeps many on/off options behind app_get_robot_setting and
app_set_robot_setting, picked by name. A beta feature can now carry that
name and the read, write and read-back go through those commands. This
adds the options the Curv 2 Flow plugin reaches this way: uncleaned area
reminder, follow low obstacles, full duplex voice and climbing arms on
high thresholds, plus Smart Charging (the optimize battery toggle), which
the official app reads from bit 74 of the feature set.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bit 105 gates the robot setting nearbycarpet_detecting_wire_status and bit
104 gates disable_sidebrush_lift_status, where 1 means on despite the
name. Both are read and written by name through the generic robot
setting commands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A beta feature can now carry choices (value and label) and name an older
option it replaces. Cleaning Pattern (bit 70, clean_direction_status) is
the first: the Floor cleaning page shows it as a row that opens a radio
dialog and writes the pick. The replacement happens after the reads, so a
robot with bit 70 whose pattern read fails keeps the old floor direction
toggle instead of losing both.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The carpet mode was sent as a one-item list. A Curv 2 Flow refuses that with -10005 "param is not an object", so choosing a carpet mode never changed it there, and leaving the Cross card stopped before Cross was switched off. The official app sends {"carpet_clean_mode": n}; both the Curv 2 Flow and the Qrevo Pro accept it (checked live by writing each robot's current value).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant