Skip to content

Let the schedule time be set to any minute, in the device's clock style - #38

Merged
DonSidro merged 1 commit into
DonSidro:masterfrom
virtitnerd:fix/schedule-time-stepper
Oct 26, 2026
Merged

DonSidro merged 1 commit into
DonSidro:masterfrom
virtitnerd:fix/schedule-time-stepper

Conversation

@virtitnerd

Copy link
Copy Markdown
Contributor

Problem

  • The minute stepper moved in steps of 15, so a schedule could not be set to an exact minute, which the official app's picker allows.
  • Stepping down from :00 wrapped to the maximum, so the minutes went :59, :44, :29, :14.
  • The picker was always 24-hour while the schedule list showed 12-hour times.

Changes

  • Minutes step by one and wrap around the range. The + and - buttons repeat while held, so a distant minute is a second of holding away rather than dozens of taps.
  • The picker and the schedule list both follow the device's clock setting: on a 12-hour device the picker shows 1 to 12 with an AM/PM button, and on a 24-hour device the list shows 17:05 instead of 05:05 PM.

Tested

./gradlew :composeApp:testDebugUnitTest: 196 tests, 0 failures, including new tests for the wrap-around and the 12/24-hour conversion. Built the Android app and installed it on a phone.

Known gaps

The iOS clock-format lookup is not compiled on Windows and needs an Xcode build to confirm.

The minute stepper only moved in steps of 15 and wrapped to the maximum, so
stepping down from :00 went to :59, which made it impossible to set the exact
minute the official app's picker allows. Minutes now step by one and wrap
around the range, and the + and - buttons repeat while held, so a distant
minute is a second of holding away rather than dozens of taps.

The picker was always 24-hour while the schedule list showed 12-hour times.
Both now follow the device's clock setting: on a 12-hour device the picker
shows 1 to 12 with an AM/PM button, and on a 24-hour device the list shows
17:05 instead of 05:05 PM. The iOS lookup is not compiled on Windows and needs
an Xcode build to confirm.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@DonSidro DonSidro left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you rebase this on #37 because it also changes ScheduleScreen ;)

@DonSidro
DonSidro merged commit 8288fa4 into DonSidro:master Oct 26, 2026
virtitnerd added a commit to virtitnerd/LocalRock that referenced this pull request Oct 26, 2026
…Repeat

Rebased onto master after DonSidro#38 and DonSidro#63. In the timer functions DonSidro#63 also
touched, this keeps the server_timer-aware versions.

- Let schedules choose vacuum, mop and suction options
- Check the robot's answer when saving a schedule, and stop sending null
- Wrap the schedule option chips so the chosen one is always visible
- Carry segments, mop, and map fields on a schedule's settings
- Add the server_timer wire format and feature-flag detection
- Speak server_timer to robots that need it
- Edit and delete a server_timer schedule by its real robot-side id
- Offer SmartPlan as a cleaning choice for schedules
- Read and write one-time schedules
- Offer the official app's Repeat choices on a schedule
- Drop "Current settings" from the schedule dialog
- Sign JSON bodies and body-less DELETEs in the Hawk plugin
- Write the cloud record of a server_timer schedule, as the official app does
- Offer only the mop routes a schedule can use

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@virtitnerd
virtitnerd deleted the fix/schedule-time-stepper branch October 27, 2026 01:37
jxt1009 pushed a commit to jxt1009/LocalRock that referenced this pull request Oct 28, 2026
…n & Go fixes

Features
- Routines: More > Routines lists the routines local_roborock_server keeps and runs one (DonSidro#27)
- Room types: pick a room type, or give a room a custom name (DonSidro#42)
- Beta features page for options newer robots advertise, such as FlexiArm, gap deep clean and dirty object detection (DonSidro#55, DonSidro#56)
- "Empty through the dock" for the robot's built-in water tank (DonSidro#31, DonSidro#40)
- Schedule time can be set to any minute and follows the phone's 12/24-hour clock (DonSidro#38)
- Sign-in screen in German, the first step of app translations (DonSidro#53, DonSidro#58)
- What's new entry for 1.4.0

Fixes
- Zone clean sends the drawn rectangles in robot coordinates with the right nesting, and reports a refused start (DonSidro#34, DonSidro#44)
- Pin & Go sends the target in robot coordinates as a bare [x, y] point (DonSidro#34, DonSidro#46)
- A refused suction, water or mop mode change falls back to set_clean_motor_mode (DonSidro#34, DonSidro#47)
- A zoomed map reaches the edge of the screen in the main map, editor and zone map (DonSidro#57, DonSidro#59), and keeps its zoom and pan while the map refreshes during cleaning (DonSidro#61)
- After a floor switch the map is requested again until the robot has loaded the new one, so the old floor's map no longer shows under the new name (DonSidro#54, DonSidro#62)
- Rooms can be renamed on robots whose room table is empty, and a refused rename no longer leaves an unused room on the server (DonSidro#33)
- Dock settings follow the dock's capabilities, and the wash interval is sent in the robot's units (DonSidro#45)
- Volume and child lock use the commands robots answer to, and show a refusal (DonSidro#32, DonSidro#39)
- A refused schedule, carpet mode or status light change shows the robot's error instead of failing silently (DonSidro#28, DonSidro#35, DonSidro#63, DonSidro#64)
- Floor type 2 shows as Carpet (DonSidro#26)
- iOS sends the host name in the MQTT TLS handshake, so reverse proxies with strict SNI work (DonSidro#29)
- System back on a settings page returns to the settings list (DonSidro#52)
- The message toast sits above the 3-button navigation bar (DonSidro#51)

Smaller changes
- README updated for current features and the iOS SNI note
virtitnerd added a commit to virtitnerd/LocalRock that referenced this pull request Nov 14, 2026
…Repeat

Rebased onto master after DonSidro#38, DonSidro#63, DonSidro#69 and DonSidro#71. In the timer functions
DonSidro#63 also touched, this keeps the server_timer-aware versions; it uses
master's getInitStatus and its live SmartPlan and Water Slide flags.

- Let schedules choose vacuum, mop and suction options
- Check the robot's answer when saving a schedule, and stop sending null
- Wrap the schedule option chips so the chosen one is always visible
- Carry segments, mop, and map fields on a schedule's settings
- Add the server_timer wire format and feature-flag detection
- Speak server_timer to robots that need it
- Edit and delete a server_timer schedule by its real robot-side id
- Offer SmartPlan as a cleaning choice for schedules
- Read and write one-time schedules
- Offer the official app's Repeat choices on a schedule
- Drop "Current settings" from the schedule dialog
- Sign JSON bodies and body-less DELETEs in the Hawk plugin
- Write the cloud record of a server_timer schedule, as the official app does
- Offer only the mop routes a schedule can use
- Read the whole 64-bit featureset when checking for server timers

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants