Skip to content

Preserve map zoom and pan during live updates - #61

Merged
DonSidro merged 2 commits into
DonSidro:masterfrom
pponce:FIX_MAP_VIEWPORT
Oct 26, 2026
Merged

DonSidro merged 2 commits into
DonSidro:masterfrom
pponce:FIX_MAP_VIEWPORT

Conversation

@pponce

@pponce pponce commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Problem

During cleaning, refreshed map snapshots reset the user's zoom and pan and restart gesture handlers.

Changes

Preserve the viewport across robot-position, path and pixel updates. Reframe on robot/floor changes, coordinate-grid changes and viewport resizing. Gesture handlers read the latest map. Double-tap still fits the map.

Independent of schedule PR #60; based on upstream master.

Validation

Includes regression tests for live refresh, robot/floor switches, coordinate changes, resizing and explicit reset. CI runs Android tests/build and iOS shared compilation.

confirmed working in my local build.

@DonSidro
DonSidro merged commit eaba8df into DonSidro:master Oct 26, 2026
@pponce
pponce deleted the FIX_MAP_VIEWPORT branch October 26, 2026 19:38
jxt1009 pushed a commit to jxt1009/LocalRock that referenced this pull request Oct 28, 2026
…n & Go fixes

Features
- Routines: More > Routines lists the routines local_roborock_server keeps and runs one (DonSidro#27)
- Room types: pick a room type, or give a room a custom name (DonSidro#42)
- Beta features page for options newer robots advertise, such as FlexiArm, gap deep clean and dirty object detection (DonSidro#55, DonSidro#56)
- "Empty through the dock" for the robot's built-in water tank (DonSidro#31, DonSidro#40)
- Schedule time can be set to any minute and follows the phone's 12/24-hour clock (DonSidro#38)
- Sign-in screen in German, the first step of app translations (DonSidro#53, DonSidro#58)
- What's new entry for 1.4.0

Fixes
- Zone clean sends the drawn rectangles in robot coordinates with the right nesting, and reports a refused start (DonSidro#34, DonSidro#44)
- Pin & Go sends the target in robot coordinates as a bare [x, y] point (DonSidro#34, DonSidro#46)
- A refused suction, water or mop mode change falls back to set_clean_motor_mode (DonSidro#34, DonSidro#47)
- A zoomed map reaches the edge of the screen in the main map, editor and zone map (DonSidro#57, DonSidro#59), and keeps its zoom and pan while the map refreshes during cleaning (DonSidro#61)
- After a floor switch the map is requested again until the robot has loaded the new one, so the old floor's map no longer shows under the new name (DonSidro#54, DonSidro#62)
- Rooms can be renamed on robots whose room table is empty, and a refused rename no longer leaves an unused room on the server (DonSidro#33)
- Dock settings follow the dock's capabilities, and the wash interval is sent in the robot's units (DonSidro#45)
- Volume and child lock use the commands robots answer to, and show a refusal (DonSidro#32, DonSidro#39)
- A refused schedule, carpet mode or status light change shows the robot's error instead of failing silently (DonSidro#28, DonSidro#35, DonSidro#63, DonSidro#64)
- Floor type 2 shows as Carpet (DonSidro#26)
- iOS sends the host name in the MQTT TLS handshake, so reverse proxies with strict SNI work (DonSidro#29)
- System back on a settings page returns to the settings list (DonSidro#52)
- The message toast sits above the 3-button navigation bar (DonSidro#51)

Smaller changes
- README updated for current features and the iOS SNI note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants