Skip to content

Show the robot's refusal when a schedule is saved, toggled or deleted (#28) - #63

Merged
DonSidro merged 1 commit into
masterfrom
fix/schedule-errors
Oct 26, 2026
Merged

DonSidro merged 1 commit into
masterfrom
fix/schedule-errors

Conversation

@DonSidro

Copy link
Copy Markdown
Owner

First part of #28. Saving, turning on or off, or deleting a schedule sent the command and ignored the robot's answer, so a refused schedule showed in the list until the screen was opened again.

set_timer, upd_timer and del_timer now check the robot's answer, and the schedule screen shows the error. The list only changes once the robot has accepted the change.

Tested on a Qrevo Curv 2 Flow (a245): saving a schedule shows "The robot refused set_timer: timer type error (code -10005)" and the list stays empty.

This does not make schedules work on that robot; it needs set_server_timer (#37) and the server's schedule support. This conflicts with #37 and #60 in the same functions; their version should win there.

…#28)

set_timer, upd_timer and del_timer now check the robot's answer, and the schedule screen reports the error instead of dropping it. A refused schedule no longer appears in the list until the screen is reopened.
@DonSidro
DonSidro merged commit 6e4e9d5 into master Oct 26, 2026
@DonSidro
DonSidro deleted the fix/schedule-errors branch October 26, 2026 19:31
virtitnerd added a commit to virtitnerd/LocalRock that referenced this pull request Oct 26, 2026
…Repeat

Rebased onto master after DonSidro#38 and DonSidro#63. In the timer functions DonSidro#63 also
touched, this keeps the server_timer-aware versions.

- Let schedules choose vacuum, mop and suction options
- Check the robot's answer when saving a schedule, and stop sending null
- Wrap the schedule option chips so the chosen one is always visible
- Carry segments, mop, and map fields on a schedule's settings
- Add the server_timer wire format and feature-flag detection
- Speak server_timer to robots that need it
- Edit and delete a server_timer schedule by its real robot-side id
- Offer SmartPlan as a cleaning choice for schedules
- Read and write one-time schedules
- Offer the official app's Repeat choices on a schedule
- Drop "Current settings" from the schedule dialog
- Sign JSON bodies and body-less DELETEs in the Hawk plugin
- Write the cloud record of a server_timer schedule, as the official app does
- Offer only the mop routes a schedule can use

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jxt1009 pushed a commit to jxt1009/LocalRock that referenced this pull request Oct 28, 2026
…n & Go fixes

Features
- Routines: More > Routines lists the routines local_roborock_server keeps and runs one (DonSidro#27)
- Room types: pick a room type, or give a room a custom name (DonSidro#42)
- Beta features page for options newer robots advertise, such as FlexiArm, gap deep clean and dirty object detection (DonSidro#55, DonSidro#56)
- "Empty through the dock" for the robot's built-in water tank (DonSidro#31, DonSidro#40)
- Schedule time can be set to any minute and follows the phone's 12/24-hour clock (DonSidro#38)
- Sign-in screen in German, the first step of app translations (DonSidro#53, DonSidro#58)
- What's new entry for 1.4.0

Fixes
- Zone clean sends the drawn rectangles in robot coordinates with the right nesting, and reports a refused start (DonSidro#34, DonSidro#44)
- Pin & Go sends the target in robot coordinates as a bare [x, y] point (DonSidro#34, DonSidro#46)
- A refused suction, water or mop mode change falls back to set_clean_motor_mode (DonSidro#34, DonSidro#47)
- A zoomed map reaches the edge of the screen in the main map, editor and zone map (DonSidro#57, DonSidro#59), and keeps its zoom and pan while the map refreshes during cleaning (DonSidro#61)
- After a floor switch the map is requested again until the robot has loaded the new one, so the old floor's map no longer shows under the new name (DonSidro#54, DonSidro#62)
- Rooms can be renamed on robots whose room table is empty, and a refused rename no longer leaves an unused room on the server (DonSidro#33)
- Dock settings follow the dock's capabilities, and the wash interval is sent in the robot's units (DonSidro#45)
- Volume and child lock use the commands robots answer to, and show a refusal (DonSidro#32, DonSidro#39)
- A refused schedule, carpet mode or status light change shows the robot's error instead of failing silently (DonSidro#28, DonSidro#35, DonSidro#63, DonSidro#64)
- Floor type 2 shows as Carpet (DonSidro#26)
- iOS sends the host name in the MQTT TLS handshake, so reverse proxies with strict SNI work (DonSidro#29)
- System back on a settings page returns to the settings list (DonSidro#52)
- The message toast sits above the 3-button navigation bar (DonSidro#51)

Smaller changes
- README updated for current features and the iOS SNI note
virtitnerd added a commit to virtitnerd/LocalRock that referenced this pull request Nov 14, 2026
…Repeat

Rebased onto master after DonSidro#38, DonSidro#63, DonSidro#69 and DonSidro#71. In the timer functions
DonSidro#63 also touched, this keeps the server_timer-aware versions; it uses
master's getInitStatus and its live SmartPlan and Water Slide flags.

- Let schedules choose vacuum, mop and suction options
- Check the robot's answer when saving a schedule, and stop sending null
- Wrap the schedule option chips so the chosen one is always visible
- Carry segments, mop, and map fields on a schedule's settings
- Add the server_timer wire format and feature-flag detection
- Speak server_timer to robots that need it
- Edit and delete a server_timer schedule by its real robot-side id
- Offer SmartPlan as a cleaning choice for schedules
- Read and write one-time schedules
- Offer the official app's Repeat choices on a schedule
- Drop "Current settings" from the schedule dialog
- Sign JSON bodies and body-less DELETEs in the Hawk plugin
- Write the cloud record of a server_timer schedule, as the official app does
- Offer only the mop routes a schedule can use
- Read the whole 64-bit featureset when checking for server timers

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant