Repository navigation
Keep never-treated units in make_did_CS2021 with float time and anticipation - #437
Merged
SvenKlaassen merged 2 commits intoNov 2, 2026
Conversation
SvenKlaassen
self-requested a review
November 2, 2026 16:44
SvenKlaassen
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The anticipation filter now keeps the never-treated units of both time types (
NaTfor datetime,inffor float), so the duplicated filter in the datetime and float branches is no longer needed.New test in
doubleml/did/tests/test_datasets.py: the data contain never-treated units for both time types and 0, 1 and 2 anticipation periods. It fails onmainfor float with anticipation.Reference to Issues or PRs
Fixes #432
PR Checklist