Repository navigation
Fix tune(tune_on_folds=True) when n_rep differs from the number of treatments - #438
Open
AsadGudzevic94 wants to merge 1 commit into
Open
AsadGudzevic94 wants to merge 1 commit into
AsadGudzevic94 wants to merge 1 commit into
Conversation
JanTeichertKluge
self-requested a review
November 2, 2026 16:51
JanTeichertKluge
approved these changes
Nov 2, 2026
JanTeichertKluge
left a comment
JanTeichertKluge
left a comment
Member
There was a problem hiding this comment.
Thanks for implementing, seems fine!
Best
Jan
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tuning_resis now a list (one per treatment) of separate lists (one per repetition), indexedtuning_res[i_d][i_rep]as it is allocated.New test
doubleml/tests/test_tune_on_folds.pyfor(n_rep, n_treat)in(1, 1), (2, 1), (1, 2), (3, 2): the returned results have one entry per treatment and repetition, and their parameters are the ones that were set. It fails onmainexcept for(1, 1).Reference to Issues or PRs
Fixes #433
PR Checklist