Repository navigation
Conversation
5 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_sensitivity_defaultsfails when run alone or on a different pytest worker fromtest_plr_defaults: it calls sensitivity analysis on a module-global PLR model that only the earlier test fits.Create and fit a local model inside the sensitivity test. The default-parameter assertions stay unchanged, and the shared model used by
test_plr_defaultsis not mutated.Validation: the sensitivity test fails before the change; sensitivity followed by PLR defaults passes after it (2 passed), confirming that neither test needs to run first. Independent automated review confirmed the fix. Formatting and lint checks pass.
Discovered during complete-suite validation of #445, which includes this commit so the integration can be validated independently of test ordering. This test-only repair can be merged separately first.