Repository navigation
fix(crash) + feat(i18n): SafeCrashlytics wrapper + expand Arabic + seed Indonesian (Phase 2 start) - #3
Open
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…ash without google-services.json
DesignActivity, LogicEditorActivity, and ViewPane each held a
FirebaseCrashlytics instance in a private final field initialized
via FirebaseCrashlytics.getInstance(). Because Sketchware Pro is
built without google-services.json, the default FirebaseApp is
never auto-initialized, so getInstance() throws IllegalStateException.
Field initializers run before onCreate, so the activity itself fails
to instantiate -- on Ahmed's Samsung A05 (SDK 35) this surfaced as:
Unable to instantiate activity ComponentInfo{pro.sketchware/
com.besome.sketch.design.DesignActivity}: java.lang.IllegalStateException:
Default FirebaseApp is not initialized in this process pro.sketchware.
Introduce pro.sketchware.utility.telemetry.SafeCrashlytics, a thin
null-safe wrapper that resolves the FirebaseCrashlytics delegate lazily
and silently no-ops every call when Firebase is unavailable. The wrapper
will start delegating automatically as soon as a FirebaseApp exists, so
re-enabling telemetry in the future is a single-line change with no
call-site updates.
Phase 2 follow-ups bundled in this commit:
- expand Arabic strings to ~160 (settings, my-projects, theme presets,
drawer extras, manage-export-url, common errors and search)
- seed Indonesian translation (values-id/strings.xml, ~100 strings)
- advertise 'id' in locales_config.xml so Android 13+ language picker
exposes the new locale
- update docs/CONTRIBUTING-i18n.md with the new shipping table
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hotfix for the Phase 1 r1 launch crash plus the first Phase 2 batch of
i18n improvements.
Crash fix (the urgent part)
v7.0.0-phase1-r1crashed on real devices the moment a project opened:DesignActivity,LogicEditorActivity, andViewPaneeach held aFirebaseCrashlyticsinstance in aprivate finalfield initialized viaFirebaseCrashlytics.getInstance(). Because Sketchware Pro is built withoutgoogle-services.json, the defaultFirebaseAppis never auto-initialized,so
getInstance()throws and the activity itself fails to instantiate.Introduce
pro.sketchware.utility.telemetry.SafeCrashlytics— a thinnull-safe wrapper that resolves the
FirebaseCrashlyticsdelegate lazilyand silently no-ops every call when Firebase is unavailable. Same public
methods (
log,recordException) so the call sites do not change. When aFirebaseAppbecomes available in the future, the wrapper starts delegatingto real Crashlytics again with no further code changes.
Phase 2 (i18n) starter batch
manage-export-url, theme presets, search, common errors, drawer extras.
id) seed translation:app/src/main/res/values-id/strings.xmlwith ~100 high-frequency strings (common words, main tabs, drawer, settings,
block categories, common errors).
app/src/main/res/xml/locales_config.xmlnow advertisesid, so theAndroid 13+ per-app language picker exposes Indonesian.
docs/CONTRIBUTING-i18n.md"Currently shipping" table refreshed.Roadmap
Sketchware-Pro-PROFESSIONAL-ROADMAP.mdwas rewritten to mark which Phase 1items shipped vs. deferred, and to lay out the Phase 2 task list with a
status column. (That doc lives outside the repo so this PR only affects code.)
Build & artifact
:app:assembleRelease— BUILD SUCCESSFUL locally.:app:testReleaseUnitTest— BUILD SUCCESSFUL (14 tests pass).SketchwarePro-v7.0.0-phase1-r2.apk(124 MB)8046aa793c9bc16a3ae5a4250dbc3647d31e82f373c47de5e6dfbbf7b4845a3cReview & Testing Checklist for Human
the
IllegalStateExceptioninDesignActivity.ViewPane(e.g. drag-and-drop view editing) to make sure the samecrash does not appear in those code paths either.
confirm the new strings render correctly (no missing keys, no RTL
layout breakage in Arabic).
SafeCrashlyticsto confirm the API surface matches whatSketchware will need if/when Firebase is re-introduced.
Notes
pre-existing
compileReleaseKotlinissue documented in ADR-0002. Thesame code builds cleanly locally; this PR does not touch the affected
Kotlin sources, so any failure on CI is unrelated to the changes here.
are still in the Phase 2 backlog and will land in subsequent PRs.
Link to Devin session: https://app.devin.ai/sessions/e3921762a25f45138ba2e0180e57b14d