Repository navigation
test(container): delete the container, section and primitive inline mirror suites, 1,467 lines - #431
Merged
Merged
Conversation
…irror suites The inline #[cfg(test)] modules of bitcursor, cipher, crc, lz77, r2007, r21_lz, reed_solomon, section, section_map, header, metadata, limits, api and object_type build synthetic byte buffers in each parser's own layout and assert its fields. They are unit tests, which this repository bans, and no job runs them since the Test job moved to tools/ci/run_test_targets.sh. Git history is the archive.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa606b16f8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unit-suite staged deletion, area container, sections and primitives. The inline
#[cfg(test)]modules of 14 files build synthetic byte buffers, bit streams and page maps in each parser's own layout and assert its fields. They are unit tests, which this repository bans, and no job runs them since the Test job moved totools/ci/run_test_targets.sh(#428). Git history is the archive.Lines removed: 1,467. Production code is unchanged: each file's
#[cfg(test)]items are its test modules (three inlimits.rs), so no test-only helper goes with them, and no item can become dead code (one used only by tests would already warn in the non-test library build, which CI compiles with-D warnings).No open PR touches these files, checked against
gh pr list --state openat push time.string_stream.rsis left out on purpose: itspub(crate) mod testssuppliesbits_ofandbuild_payloadto the test modules of 33 files underentities/,objects/andtables/, some of which the open PRs #323 to #412 touch, so it goes after the last of them.reader.rs,object.rs,version.rs,header_vars.rsandclasses.rswait for the same PRs.Coverage of the area
samples,corpus_roundtrip,class_censusandr2013_entity_values(classreal) read the 19 corpus drawings; the Corpus job measures every pinned drawing againsttools/corpus/baseline.tsv, so a changed bit code, CRC, cipher, LZ77 or section-map result moves a decoded or errored count.probe_data_page_header --strict(the R2004-family page header and its CRC32 on every data page),probe_header_vars(the header CRC and every stream boundary),probe_r2007_rs(every Reed-Solomon codeword of every pinned R2007 drawing, intact, re-encoded and corrected after damage), andprobe_code_page.examples/spec_examples.object_type:code_table_agreement(classcontract) checks it against the dispatcher's table and the specification's Table 4.limits,api: no job checks the relationship between the three limit profiles or the diagnostics bookkeeping directly; both are exercised only through the CLIs and the corpus counts. Neither is a check on a value that real files give.Spec reference
Not a decoder change. No corpus count moves:
tools/corpus/baseline.tsvandtools/oracle/baseline.tsvare untouched.Test plan
cargo fmt --all -- --checkpasses (run locally; nothing else is built here).--all-targets --all-features -D warnings, which builds the lib test target, where a helper left without a user fails as dead code), the six Test legs, Corpus (public DWG) withtools/corpus/baseline.tsvandtools/oracle/baseline.tsvunchanged, and Coverage smoke. This branch is based on main before chore(ci): class every tests/ target and run all but the unit ones #428, so its Test legs ran the oldcargo test; chore(ci): class every tests/ target and run all but the unit ones #428's run 40674359229 shows the classed runner, and CI runs again on this branch once chore(ci): class every tests/ target and run all but the unit ones #428 lands.Source-provenance declaration
By submitting this PR I certify that my contribution does not incorporate executable code from any source whose license is incompatible with Apache-2.0. Specifically:
CLEANROOM.md).dwg-rsis Apache-2.0 and must remain compatible.My contribution is based on:
See
CLEANROOM.mdfor the full allowed/forbidden source list and the honest scope of what "clean-room" means for this project.Developer Certificate of Origin
By submitting this PR, I certify that the contribution complies with the Developer Certificate of Origin 1.1. Specifically, I affirm that the contribution is my own work (or rightfully licensed to me) and that it can be distributed under the project's Apache-2.0 license.