[DrunkOnJava]

Summary

Unit-suite staged deletion, area object decoders. The inline #[cfg(test)] modules of 13 files under src/objects/ build synthetic bit streams in each decoder's own field layout and assert the fields they decode, or round-trip them through a hand-written encoder. They are unit tests, which this repository bans, and no job runs them since the Test job moved to tools/ci/run_test_targets.sh (#428). Git history is the archive.

File (src/objects/)	Tests	Lines
acad_layout.rs	5	162
xdata.rs	4	95
acad_plot_settings.rs	3	91
acad_group.rs	5	90
acad_property_set_data.rs	4	90
acad_scale.rs	5	88
acad_mlinestyle.rs	4	81
proxy_entity.rs	4	65
proxy_object.rs	4	63
custom_dict_entry.rs	4	60
acad_material.rs	2	46
dictionary_var.rs	3	41
placeholder.rs	3	35

Lines removed: 1,021 (50 tests; 1 line reworded). Production code is unchanged apart from one doc line: each file's only #[cfg(test)] item is its test module, so no test-only helper goes with it. acad_material.rs documented AcadMaterial as "kept with its tests"; it is public API that Material supersedes, so it stays and the line now says that.

Skipped: files an open PR touches, and the four they pin

Checked against gh pr list --state open at push time.

• control, class_map_extension, dictionary, modern and xrecord keep their inline suites: feat(container): open and walk AC1012 (R13), pinned on 22 real drawings (#119) #323, feat(objects): R13 and R14 reference closure from the RL inside the common data (#84), stacked on #323 #324, fix(entities): R13 takes the R13-R14 branch of TEXT, VIEWPORT, TRACE, DIMSTYLE and LEADER (#119) #355, docs: the record types three R13 sets hold, and the ones still unmeasured (#119) #356, feat(entities): route MINSERT (8) and decode §20.4.10's grid fields (#141) #410 and feat(corpus): pin the 122 US Forest Service AC1012 drawings by Wayback URL (#345) #412 (the R13 stack) touch all five. objects/mod.rs and render_environment.rs have no inline tests.
• acad_detail_view_style, acad_mleader_style, acad_section_view_style and acad_visual_style keep theirs too, though no open PR touches them. Their test modules are the last users of modern::tests::r2004_object_prefix and write_inline_tv, two helpers in modern.rs, a file the stack touches. Deleting those four suites leaves the helpers dead in the lib test build, which -D warnings rejects: the first push of this PR did exactly that (Test (windows-latest, stable), function r2004_object_prefix is never used), and the second commit restores the four. They go with modern.rs.
• string_stream.rs, whose pub(crate) mod tests the test modules of these files use, goes after the last of them.

Coverage of the area

Every decoder here is self-validating: a field list must end exactly on the record's data-stream boundary, or it returns an error. What checks it now is the Corpus job, on every pinned drawing:

• the per-file decoded, skipped and errored counts of tools/corpus/baseline.tsv;
• the DXF value oracle (tools/oracle/baseline.tsv), which has rows for LAYOUT (acad_layout), MLINESTYLE, SCALE, DICTIONARYVAR and ACDB_PLACEHOLDER among these files;
• canonical_corpus and the class-census probes on the committed canonical fixtures.

The oracle has no row for acad_group, acad_material, acad_plot_settings, acad_property_set_data, custom_dict_entry, proxy_entity, proxy_object and xdata. For those, the check is the errored count, which only sees a type the pinned drawings contain; the deletion removes the only other check.

Spec reference

Not a decoder change. No corpus count moves: tools/corpus/baseline.tsv and tools/oracle/baseline.tsv are untouched.

Test plan

• cargo fmt --all -- --check passes (run locally; nothing else is built here).
• Checked offline that no helper in a retained #[cfg(test)] module loses its last user (the failure above); CI is the compiler.
• CI evidence, run 40676245538, all 25 checks green: Clippy (--all-targets --all-features -D warnings, which builds the lib test target, where a helper left without a user fails as dead code), the six Test legs, Corpus (public DWG) with tools/corpus/baseline.tsv and tools/oracle/baseline.tsv unchanged, and Coverage smoke. This branch is based on main before chore(ci): class every tests/ target and run all but the unit ones #428, so its Test legs ran the old cargo test; chore(ci): class every tests/ target and run all but the unit ones #428's run 40674359229 shows the classed runner, and CI runs again on this branch once chore(ci): class every tests/ target and run all but the unit ones #428 lands.

Source-provenance declaration

By submitting this PR I certify that my contribution does not incorporate executable code from any source whose license is incompatible with Apache-2.0. Specifically:

• No Autodesk DWG SDK source (RealDWG, ObjectARX, ObjectDBX) or NDA-protected Autodesk documentation was consulted or imported.
• No Open Design Alliance Teigha / Drawings SDK source was consulted or imported. The ODA's public Open Design Specification for .dwg files PDF is explicitly allowed (see CLEANROOM.md).
• No GPL-licensed DWG implementation source (LibreDWG, etc.) was consulted or imported. This matters because dwg-rs is Apache-2.0 and must remain compatible.

My contribution is based on:

• The ODA's freely-redistributable Open Design Specification for .dwg files (v5.4.1);
• Public reverse-engineering notes, research papers, or blog posts cited inline;
• Reading algorithm-description comments (not executable code) in permissively-licensed projects (MIT / Apache / BSD) to resolve spec ambiguities: none were read for this change.

See CLEANROOM.md for the full allowed/forbidden source list and the honest scope of what "clean-room" means for this project.

Developer Certificate of Origin

By submitting this PR, I certify that the contribution complies with the Developer Certificate of Origin 1.1. Specifically, I affirm that the contribution is my own work (or rightfully licensed to me) and that it can be distributed under the project's Apache-2.0 license.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-28T13:14:20.162170Z	deff1fe	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.