Repository navigation
ci: the Rust install is tried three times, so a failed download does not turn a job red (#1457) - #1506
Merged
Conversation
…not turn a job red (#1457)
DrunkOnJava
marked this pull request as ready for review
November 6, 2026 00:08
DrunkOnJava
enabled auto-merge (squash)
November 6, 2026 00:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rustup toolchain installfailed once onfull / build + real files / macos-26 / stableon #1483 at 1811752 with "could not download file from 'https://static.rust-lang.org/dist/channel-rust-stable.toml.sha256'", with nothing wrong in the code. rustup's own retries are over in seconds. #1491 put the install in one composite action, so one change now covers every job.The install is tried three times, 20 s and 40 s apart, each failure leaving a warning. A toolchain that really can't be installed still fails the job, with an error, about a minute later.
The one other rustup download in CI,
rustup component add rustfmtinifcopenshell-validate, moves into that job's setup step ascomponent: rustfmt, so it goes through the same retry.Cache keys don't move: no toolchain and no environment variable changes, and Swatinem/rust-cache v2.9.3 hashes neither the action file nor the installed components. Every rust-cache key on this PR's CI run 42134631531 equals the same job's on main's run 42131995046, the IfcOpenShell job's included (
v0-rust-ci-release-Linux-x64-cdee7d24-2ff012fc).Refs #1457.
Verification
bash --noprofile --norc -eo pipefail(as GitHub runsshell: bash) against a fakerustup,rustcandsleep:GITHUB_ENV.GITHUB_ENV.actionlintexits 0.tools/ci/check-workflows.pywasn't run locally (no PyYAML here); CI runs it.No output,
src/or gate file changes, so no Measure.