Repository navigation
docs(re): Core Interior's saved-mesh bodies are 138, not RE-78's 158: the 20 plates and 116 rooms were outlines before the option landed (#1492) - #1508
Merged
Conversation
…-drawn shading devices by shape (#1492) mesh_bodies_vs_ifc.py scores BodySource saved_graphics_mesh, and the 20 shading devices have not been one since RE-95 closed their outlines: saved_meshes::attach leaves a resolved profile alone. This is that scorer with every IfcShadingDevice selected, and a count of what drew them (BodySource, ProfileResolved) before its table.
…main, the plates and rooms being outlines before the option landed (#1492) The count of 158 (132 doors, 6 windows, 20 shading devices) was measured on 2026-09-27. RE-95 (#467) closed the 20 plates' outlines and RE-101 (#473) the rooms' on 2026-09-28; saved_meshes::attach replaces only a body whose profile is not resolved, as it did at 7386177, the first commit on main with --saved-meshes. RE-78 now says so under its first table, and its result line no longer names the shading devices.
…red by shape and by outline (#1492) Measure run 42133202790 (Core Interior, --saved-meshes, daf3610): shading_bodies_vs_ifc scores 20 of 20 plates within 0.01% of Revit's volume and every vertex within 0.001 ft both ways, plan_profiles_vs_ifc 20 of 20 in area and outline; the saved-mesh scorers score 138 bodies and no plate.
DrunkOnJava
marked this pull request as ready for review
November 6, 2026 00:16
DrunkOnJava
enabled auto-merge (squash)
November 6, 2026 00:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RE-78 counted 158 saved-mesh bodies on Core Interior (132 doors, 6 windows, 20 shading devices);
mesh_bodies_vs_ifcandrvt-ifc --saved-meshescount 138. Nothing changed onmain: the 158 was measured on 2026-09-27, when the 20 plates and the 116 rooms were record boxes. RE-95 (#467, 6e0dfaa) closed the plates' sketch outlines and RE-101 (#473, 68a44c0) gave the rooms their stored-solid outlines on 2026-09-28, andsaved_meshes::attachreplaces only a body whoseProfileResolvedis false, as it did at 7386177, the first commit onmainwith--saved-meshes. No export changes and no body that measured exact was lost.Motivation
#1492: the pages were corrected to 138 of 138 in #1484 without saying why the 20 stopped being scored.
Changes
reports/element-framing/RE-78-saved-graphics-meshes.md: the result line stops naming the shading devices, the Core Interior shading-device row says it is from before RE-95, and a dated note under the first table gives the commits and the rule. The Snowdon rows are said to be from the same earlier tree, local only and not re-run.tools/re/shading_bodies_vs_ifc.py:mesh_bodies_vs_ifcwith everyIfcShadingDeviceselected whatever itsBodySource, and a count of theBodySourceandProfileResolvedof the plates before its table. Run by name through-f scorers=(asslab_bodies_vs_ifcis); not in the standing scorer list.changelog.d/research/1492-shading-plates-not-saved-meshes.md.Testing
Unit tests are banned in this repository; none added.
git merge-base --is-ancestor 6e0dfaae 73861770and... 68a44c05 73861770both hold,git show 73861770:src/ifc/saved_meshes.rshas the|| profile_resolvedskip (line 75), and PR feat(ifc): draw family instances from the meshes Revit saved for display, opt-in (#255) (#227) (RE-78) #420's own body says its Core Interior row (158) is from before its rebase ontomain. The Measure run that body cites (36717043673) exported IFC byte-identical tomain's, so it did not draw the meshes and did not re-measure the 158.--saved-meshes,e024f03c):rvt-ifcprints138 of 138 bounding-box bodies drawn from their saved graphics, andmesh_bodies_vs_ifcandsaved_meshes_vs_ifcscore 132 doors and 6 windows, no shading device.core-interior,-f ifc_flags=--saved-meshes, scorersplan_profiles_vs_ifc mesh_bodies_vs_ifc saved_meshes_vs_ifc shading_bodies_vs_ifc; codedaf36102, scorers from3fb0d241; success), read back:BodySourcepartition_element_record_bboxwithProfileResolvedtrue (the record-box source stays on a body whose outline is resolved).shading_bodies_vs_ifc): volume within 0.01% on 20 of 20, every vertex within 0.001 ft both ways on 20 of 20, Revit's vertices on rvt-rs's surface on 20 of 20; the largest distance 1.539e-06 ft (10Floor:Structural Slab, 10Floor:Arch Topping Slab - 2").plan_profiles_vs_ifc): area within 0.1%, vertices and outline within 0.01 ft, 20 of 20 (and 80 of 80IfcSlab).mesh_bodies_vs_ifcandsaved_meshes_vs_ifcscore 138 bodies (132 doors, 6 windows), no plate and no room;rvt-ifcprints138 of 138 bounding-box bodies drawn from their saved graphics.Audit-honesty checklist
changelog.d/research/Legal and contribution hygiene
Breaking changes
None. No
src/change, no export change.Related issues
Closes #1492.