Repository navigation
research(elements): what separates the water closet tank Revit's export lacks from the fixtures it holds (#1496) (RE-363) - #1513
Draft
DrunkOnJava wants to merge 5 commits into
Draft
DrunkOnJava wants to merge 5 commits into
DrunkOnJava wants to merge 5 commits into
Conversation
… closet tank Revit's export lacks from the fixtures it holds (#1496) (RE-363)
…by reference to a reference (#1496)
…or a surface and scores the empty ones against Revit's export (#1496)
…default export and scores the hidden-branch rule (#1496)
…es and structural columns beside the full pass (#1496)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RE-363 reads, from the bytes, what separates RE1 Plumbing's water closet tank 442378 (written by rvt-rs, absent from Revit's export) from the plumbing fixtures Revit does export, and scores each candidate rule by how many of Revit's own fixtures it would drop.
Motivation
#1496. The candidates are the four in the issue (nested shared-component status, a container or host reference, a FamilyInstance super-component field, the family's category) and one read from revit-ifc's FamilyInstanceExporter (a non-door, non-window instance with no 3D solid or mesh gets no entity; RE-312 landed that principle for IfcSpace instances).
Changes
re363count lines may leave a held-out model.Testing
No unit tests. Not yet measured on this head: the first filtered Measure run is dispatched from it.
Related issues
Refs #1496