Skip to content

Preserve file info state across M36 retries - #1242

Open
Old-Ding wants to merge 1 commit into
Duet3D:3.6-devfrom
Old-Ding:fix-m36-fileinfo-state
Open

Preserve file info state across M36 retries#1242
Old-Ding wants to merge 1 commit into
Duet3D:3.6-devfrom
Old-Ding:fix-m36-fileinfo-state

Conversation

@Old-Ding

@Old-Ding Old-Ding commented Jul 5, 2026

Copy link
Copy Markdown

Fixes #1096.\n\nSummary:\n- Preserve the named-file info response state across GetFileInfoResponse retries.\n- Reuse the same GCodeFileInfo and GlobalVariables until the JSON response is emitted, so customInfo collected during chunked parsing is not lost while a print is running.\n\nTesting:\n- git diff --check HEAD~1..HEAD\n- git ls-files --eol src/Platform/RepRap.cpp src/Platform/RepRap.h\n\nNot run: full firmware build, because this local workspace is missing arm-none-eabi-g++, Eclipse headless build, and the required sibling dependencies CANlib/CoreN2G/RRFLibraries.

CI notes

  • Current CLAAssistant failure is a contributor license agreement gate.
  • This is an account/legal gate, not a code failure in the M36 retry state diff.

Generated-by: OpenAI Codex
Signed-off-by: aineoae86-sys <ai.neo.ae86@gmail.com>
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the Duet3D CLA v2.0 and I hereby sign it


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

M36 with a filename doesn't return the customInfo if a print job is running

2 participants