Preserve file info state across M36 retries - #1242
Open
Old-Ding wants to merge 1 commit into
Open
Conversation
Generated-by: OpenAI Codex Signed-off-by: aineoae86-sys <ai.neo.ae86@gmail.com>
|
I have read the Duet3D CLA v2.0 and I hereby sign it You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1096.\n\nSummary:\n- Preserve the named-file info response state across GetFileInfoResponse retries.\n- Reuse the same GCodeFileInfo and GlobalVariables until the JSON response is emitted, so customInfo collected during chunked parsing is not lost while a print is running.\n\nTesting:\n- git diff --check HEAD~1..HEAD\n- git ls-files --eol src/Platform/RepRap.cpp src/Platform/RepRap.h\n\nNot run: full firmware build, because this local workspace is missing arm-none-eabi-g++, Eclipse headless build, and the required sibling dependencies CANlib/CoreN2G/RRFLibraries.
CI notes
CLAAssistantfailure is a contributor license agreement gate.