Repository navigation
fix: refactor pycon registration validation logic and add unit tests - #138
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Zero Price Registrations on Paid Events & Refactor PyCon Registration Flow
Context
When
event.paidEventisTrue, the backend previously required a verifiedtransactionIdunless a 100% discount code was applied. If an event offered a free ticket tier (price = 0) or temporarily waived ticket fees, the frontend skipped the payment gateway (total === 0), but the backend rejected the registration with a400 Bad Requestdue to a missing/unverified transaction ID.Key Changes
(base_price * (1 - discount)) + sprint_day_price. If the total is<= 0, the registration is marked as free and payment transaction verification is bypassed.sprintDayPrice > 0) still require payment transaction verification.__resolve_ticket_type_and_price,__resolve_discount, and__validate_payment_transaction.tests/test_pycon_registration_usecase.pycovering 0-dollar tickets, paid tickets, add-on sprint day fees, and 100% discounts.