Skip to content

Remove pkg_resources runtime dependency - #461

Merged
mtiberti merged 1 commit into
ELELAB:mainfrom
Mirochill:fix-392-importlib-resources
Jul 29, 2026
Merged

Remove pkg_resources runtime dependency#461
mtiberti merged 1 commit into
ELELAB:mainfrom
Mirochill:fix-392-importlib-resources

Conversation

@Mirochill

Copy link
Copy Markdown
Contributor

Summary

  • replace pkg_resources.resource_filename() with importlib.resources when
    reading the packaged phospho-SLiM data file
  • remove the runtime setuptools dependency that was only needed for
    pkg_resources, while retaining setuptools as the build backend

Rationale

mavisp/modules.py currently imports pkg_resources while loading packaged
data. Recent setuptools installations no longer provide that module, which
prevents the MAVISp package from being used in those environments. The package
already requires Python 3.12 or newer, so the standard-library resource API can
provide the same packaged-file access without a setuptools runtime dependency.

Fixes #392

Validation

  • git diff --check HEAD~1..HEAD
  • static search for remaining pkg_resources references in mavisp and
    pyproject.toml
  • Not run locally

@Mirochill

Copy link
Copy Markdown
Contributor Author

Disclosure for this PR as requested on #462: both #461 and #462 were prepared with AI assistance through this GitHub account, not by a project-side bot. The changes were kept limited to the reported issues, and I checked the final diffs for scope and provenance. I did not run local tests; I only did static diff review, and I do not see CI checks published for these branches. If AI-assisted contributions are not acceptable for this project, I can close the PRs.

@mtiberti
mtiberti marked this pull request as ready for review July 29, 2026 08:16
@mtiberti

Copy link
Copy Markdown
Contributor

thank you @Mirochill and sorry for the delay - I've tested this and looks good. I'm merging. Thank you for your contribution!

@mtiberti
mtiberti merged commit 3e83c4e into ELELAB:main Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove dependency from pkg_resources

2 participants