Repository navigation
fix: preserve forced tool selection through fallback (v0.30.59) - #1010
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
mylukin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sonnet 5.5 accepts ordinary tools but rejects forced
tool_choice(any/ namedtool). Helm previously sent these requests anyway and stopped the chain on the resulting 400.Add an optional
supportsForcedToolChoicecapability and mark Sonnet 5.5 unsupported. Skip it before token counting or execution, retain the client's tool requirement for compatible fallback models, and show a clear skip reason. Existing deterministic invalid-request handling remains unchanged; no compatible candidate still returns 422.Validation: 379 focused tests passed, including native Anthropic normalization and streaming/non-streaming fallback; shared/core/gateway typechecks, targeted Biome/Prettier checks, and
git diff --checkpassed. No database migration. Production rollout requires both the new image and capability configuration.Release v0.30.59: ran
pnpm release:prepare 0.30.59and recorded official stable Grok 1.0.70, Claude Code 2.1.312, and Codex 0.165.0 with its same-tag model catalog. A read-only comparison of verified Claude binaries found three remote-worker ticket headers; they remain excluded and now have regression assertions. No trusted-header expansion. The official Codex snapshot adds Terra metadata without changing lane priorities.Additional validation: 232 release, protocol, identity, and locale tests passed. The initial CI locale-key mismatch is fixed across every supported admin language. Deployment will preserve server-specific routing and update the Sonnet capability only on the direct Anthropic instance; the LAN relay represents a remote fallback chain.