fix(tunnel): add manual routes to the derived ones instead of replacing them - #32
Merged
Merged
Conversation
Collaborator
|
把多余的 comment 清理掉后，这个 pr 可以合并 |
chenx-dust
force-pushed
the
pr/additive-routes
branch
from
August 11, 2026 05:25
fd55430 to
e0db685
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildIPv4Routestreats manual routes as a replacement for the derived ones, soconfiguring a single manual route drops every peer's proxied subnet, the local virtual
address and the magic DNS route along with it.
On iOS
includedRoutesis the only way a route ever reaches the tun device -- there isno system routing table to fall back on -- so those destinations simply become
unreachable.
Adds the two sets together instead. The existing overlap pass already removes whatever
is redundant.