Skip to content

telemetry_streamer: same set-once-header + auto-reconnect token-expiry bug as #39 #114

Description

@thesprockee

Found during #39's fix (PR #113). src/runtime/server/telemetry_streamer.cpp:41-51 has the identical pattern: sets the Authorization header once at Connect, and ixwebsocket auto-reconnects reusing that stored header on every retry. Its token comes from config's telemetry_token or falls back to the ServerDB token. Same class of bug as #39 (reconnect after token expiry gets rejected and never recovers) — likely the same fix shape applies (refresh-on-401 before the next reconnect attempt).

Activity

  1. thesprockee commented on Oct 7, 2026

    @thesprockee
    MemberAuthor

    Triage: still true. telemetry_streamer.cpp:41-44 sets the Authorization header once, auto-reconnect is on (:51-53), and the Error case (:75-83) has no 401 handling. The pattern to copy is websocket_client.cpp:148-211 (SetBearerTokenRefresher, ApplyBearerToken, RefreshBearerTokenAfterRejection). Plan (about 25 lines over telemetry_streamer.{h,cpp} and gameserver.cpp:1645-1654): refresh only when the token came from the ServerDB fallback, not when telemetry_token is configured; test with the same fake-server harness test_websocket_client_auth uses. Not done in this pass.

  2. added a commit that references this issue on Oct 9, 2026
  3. added a commit that references this issue on Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions