Skip to content

ws_bridge: stripping format=evr for matchmaker connections can concatenate the path and query #116

Description

@thesprockee

Found during #41's extension (PR #109). ws_bridge.cpp:1008-1020 strips "format=evr&" from the URI for matchmaker connections (conn >= 2). If nevr_socket_uri's query starts with "?format=evr&discordid=...&password=...", stripping "format=evr&" together removes the "?" along with it: "wss://g.example/ws?format=evr&discordid=1&password=pw" becomes "wss://g.example/wsdiscordid=1&password=pw" — path and query concatenated with no separator.

Doesn't trigger with the current example config (docs/reference/example-config.yaml:175 doesn't put format=evr first), so this is latent, not necessarily hit today. Pre-existing, not introduced by #41's fix. Needs its own look at the stripping logic — probably wants to strip through the next & and reinsert a single separator, rather than assuming format=evr is removable as a prefix.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions