Repository navigation
server_context: entrant snapshot is copied once at Initialize and never refreshed #38
Description
Activity
- added a commit that references this issue
on Oct 6, 2026 Fixed in PR #111 (88df8f5). Opus review confirmed both claims independently via ReVault: the 0xD8 stride (confirmed from the element allocator, constructor AND destructor, not just the 3 original call sites — the last field ends exactly at 0xD8, so appending the 0x38-byte tail at +0xA0 instead of inserting it mid-struct is correct), and the live-read's thread safety for the 3 primary readers (smite, per-tick scan — confirmed on the game's own CNSLobby::Update thread). The loadout handlers' thread-safety is inference, not full proof — broadcaster-callback dispatch thread wasn't provable from static analysis alone.
One correction to my commit message: the call restoring the lobby pointer was 26b6b3d, not 2e90317 as I'd said.
- added a commit that references this issue
on Oct 6, 2026
ServerContextcopies the lobby's entrants once and serves every later accessor from that copy.src/runtime/server/server_context.cpp:47-50fillm_cachedEntrantsinInitialize;:78clears it inTerminate; those are the only writers.:189-193(by index) and:203(count) use the cached copy.Effect: entrants that join or leave after initialization are not reflected. Needs a decision on the refresh point (per session event vs on read).
Source:
f94be4168caf22fb79a3fee9e8c668b588618760:docs/audits/2026-09-26-runtime-bug-hunt.md(entrant-snapshot-never-refreshed). Re-verified againstmain@1e23615on 2026-09-30; read the archived record withgit show <sha>:<path>. Audit records are being retired in favour of issues.