docs(gameserver): fix stale token-auth-migration.md citation - #125
Merged
Merged
Conversation
gameserver.cpp:1310 cited docs/guides/token-auth-migration.md directly, but 1d75593 deleted that file during the 2026-07-26 doc cleanup. Point the comment at the historical sha (verified against git history, same pattern already used at the nearby line 1501 citation added by #41/ PR #109) and note where the as-built facts now live. Co-Authored-By: nevr-runtime <agents@sprock.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gameserver.cpp:1310citeddocs/guides/token-auth-migration.mddirectly, but1d75593(2026-07-26 doc cleanup) deleted that file.29ce275710ad4c779d118eafc638fef613343e28:docs/guides/token-auth-migration.md), the same pattern already in use two hundred lines down at the citation PR fix(gameserver): percent-encode ServerDB URI query values (#41) #109 added, and notes the as-built facts now live indocs/design/2026-06-29-serverdb-token-auth.md.Before
// Uses the non-interactive password RPC (docs/guides/token-auth-migration.md F1):After
Checker-gap finding (not fixed here, scope-limited per the issue)
tools/verify_doc_paths.pyonly scans tracked*.mdfiles plus.claude/{agents,skills}(seeall_doc_files()/citations()). It never looks at.cpp/.hcomments, so the stale citation ingameserver.cppwas invisible tojust verify'sdoc-pathssensor the whole time it was wrong, and this fix isn't verified by that sensor either — it was checked manually (git log -1 --format=%H -- docs/guides/token-auth-migration.md,git cat-file -e <sha>:<path>). Extending the sensor to scan C++ comments is a bigger, separate change (source-wide regex scanning, new false-positive surface) and not "clearly low-risk," so I'm filing it as a follow-up rather than doing it here.Test plan
CMAKE_BUILD_PARALLEL_LEVEL=4 just verify— green,doc-paths: OK (all claimed repo paths resolve; 8 historical citation(s) verified against git history)